You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/07 06:11:32 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #9694: MINOR: Change the input type of DescribeAclsResponse#aclsResources from Collection to Iterable to avoid creating useless collection

chia7712 commented on a change in pull request #9694:
URL: https://github.com/apache/kafka/pull/9694#discussion_r537254318



##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -2509,12 +2509,10 @@ class KafkaApis(val requestChannel: RequestChannel,
             .setThrottleTimeMs(requestThrottleMs)))
       case Some(auth) =>
         val filter = describeAclsRequest.filter

Review comment:
       Could we avoid this local variable?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org