You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/04/08 02:26:55 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9581: libswoc: Replace ts::file with swoc::file

SolidWallOfCode commented on PR #9581:
URL: https://github.com/apache/trafficserver/pull/9581#issuecomment-1500766611

   The biggest pain not related to OSX was Gancho implemented `remove_all` but named it `remove`, which is also in `std::filesystem` but does something different (i.e. recursive vs. regular file only). There were many places where `remove` was used to clean a directory, which no longer works. I changed the names for `std::filesystem` compliance. I'm not sure why Gancho used slightly different names.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org