You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/05/12 13:58:04 UTC

Review Request 59228: Supprt boot2docker & docker-machine in Log Search integration test module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59228/
-----------------------------------------------------------

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-21004
    https://issues.apache.org/jira/browse/AMBARI-21004


Repository: ambari


Description
-------

Adding $docker.host property to it framework, with that we can configure to use specific ip/host for docker (localhost is only works with docker-for-mac or unix docker installation)

Also remove suffixes from story names


Diffs
-----

  ambari-logsearch/README.md 4123a52 
  ambari-logsearch/ambari-logsearch-it/pom.xml cdb76a5 
  ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java a7dd409 
  ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java eb2a180 
  ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story 0af00f5 
  ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_tests.story PRE-CREATION 
  ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story 388e624 
  ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_tests.story PRE-CREATION 


Diff: https://reviews.apache.org/r/59228/diff/1/


Testing
-------

done.


Thanks,

Oliver Szabo


Re: Review Request 59228: Supprt boot2docker & docker-machine in Log Search integration test module

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59228/#review174803
-----------------------------------------------------------


Ship it!




Ship It!

- Miklos Gergely


On May 12, 2017, 1:58 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59228/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 1:58 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21004
>     https://issues.apache.org/jira/browse/AMBARI-21004
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding $docker.host property to it framework, with that we can configure to use specific ip/host for docker (localhost is only works with docker-for-mac or unix docker installation)
> 
> Also remove suffixes from story names
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/README.md 4123a52 
>   ambari-logsearch/ambari-logsearch-it/pom.xml cdb76a5 
>   ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java a7dd409 
>   ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java eb2a180 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story 0af00f5 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_tests.story PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story 388e624 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_tests.story PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59228/diff/1/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 59228: Supprt boot2docker & docker-machine in Log Search integration test module

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59228/#review174793
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On May 12, 2017, 1:58 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59228/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 1:58 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21004
>     https://issues.apache.org/jira/browse/AMBARI-21004
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding $docker.host property to it framework, with that we can configure to use specific ip/host for docker (localhost is only works with docker-for-mac or unix docker installation)
> 
> Also remove suffixes from story names
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/README.md 4123a52 
>   ambari-logsearch/ambari-logsearch-it/pom.xml cdb76a5 
>   ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/AbstractLogSearchSteps.java a7dd409 
>   ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java eb2a180 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_query_story.story 0af00f5 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_api_tests.story PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_story.story 388e624 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/logfeeder_parsing_tests.story PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59228/diff/1/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>