You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2023/06/13 06:55:45 UTC

[GitHub] [superset] mistercrunch opened a new pull request, #24377: [WiP] chore: bump eslint-related libs

mistercrunch opened a new pull request, #24377:
URL: https://github.com/apache/superset/pull/24377

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] chore: cleanup eslint-related warnings - bump libs - fix tsc warnings [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch closed pull request #24377: chore: cleanup eslint-related warnings - bump libs - fix tsc warnings
URL: https://github.com/apache/superset/pull/24377


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mistercrunch commented on a diff in pull request #24377: chore: bump eslint-related libs

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #24377:
URL: https://github.com/apache/superset/pull/24377#discussion_r1230274145


##########
superset-frontend/cypress-base/cypress/utils/index.ts:
##########
@@ -18,6 +18,8 @@
  */
 import { getChartAlias, Slice } from 'cypress/utils/vizPlugins';
 
+/* eslint-disable cypress/unsafe-to-chain-command */

Review Comment:
   idk the merit of that particular rule and it gave me quite a bit of trouble since I couldn't disable it globally for reasons beyond my understanding. 
   
   Philosophically though, I think we need to move away from warnings as they muddy the output and slip over time. I think we should go full on boolean on lint rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] eschutho commented on a diff in pull request #24377: chore: bump eslint-related libs

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #24377:
URL: https://github.com/apache/superset/pull/24377#discussion_r1229950121


##########
superset-frontend/cypress-base/cypress/utils/index.ts:
##########
@@ -18,6 +18,8 @@
  */
 import { getChartAlias, Slice } from 'cypress/utils/vizPlugins';
 
+/* eslint-disable cypress/unsafe-to-chain-command */

Review Comment:
   are these inline ignores something that we should be coming back around later to fix, or should we ignore them globally?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org