You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2024/05/14 04:30:32 UTC
[PR] [incubator-kie-drools-5924] [new-parser] Disable DRLIncompleteCodeTest [incubator-kie-drools]
tkobayas opened a new pull request, #5941:
URL: https://github.com/apache/incubator-kie-drools/pull/5941
## Issue
- https://github.com/apache/incubator-kie-drools/issues/5924
```
DrlParser parser = new DrlParser(LanguageLevelOption.DRL5);
PackageDescr descr = parser.parse(true, input);
```
`parse(true, ` means that it's in Editor mode. When Editor mode:
- `parser` method returns non-null PackageDescr even in case of parse error
- parser provides information for Editor through `parser.getEditorSentences()`. e.g. the current position is at `Location.LOCATION_RHS`
Here "Editor" means Eclipse plugin and web workbench, which had already retired in Drools 8.
The next DRL Editor aims at LSP based ones. So I think there is no reason to implement the Editor mode and pass `DRLIncompleteCodeTest`. Implementing the Editor mode may not be a large effort, but it would pollute `DRLVisitorImpl` code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-5924] [new-parser] Disable DRLIncompleteCodeTest [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #5941:
URL: https://github.com/apache/incubator-kie-drools/pull/5941#issuecomment-2109260915
@yurloc @mariofusco @gitgabrio Please review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-5924] [new-parser] Remove DRLIncompleteCodeTest [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #5941:
URL: https://github.com/apache/incubator-kie-drools/pull/5941#issuecomment-2109724372
> I'd rather completely remove this test instead of simply flag it as ignored. I don't see how it could be useful in future.
> Please consider also removing/ignoring
> * `org.drools.mvel.compiler.lang.RuleParserTest#testPackageWithError`
> * `org.drools.mvel.compiler.lang.RuleParserTest#testPackageWithError2`
> which use the parser in editor mode.
@mariofusco @yurloc Thanks, both done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-5924] [new-parser] Disable DRLIncompleteCodeTest [incubator-kie-drools]
Posted by "yurloc (via GitHub)" <gi...@apache.org>.
yurloc commented on PR #5941:
URL: https://github.com/apache/incubator-kie-drools/pull/5941#issuecomment-2109429095
@tkobayas Please consider also removing/ignoring
- `org.drools.mvel.compiler.lang.RuleParserTest#testPackageWithError`
- `org.drools.mvel.compiler.lang.RuleParserTest#testPackageWithError2`
which use the parser in editor mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-drools-5924] [new-parser] Remove DRLIncompleteCodeTest [incubator-kie-drools]
Posted by "mariofusco (via GitHub)" <gi...@apache.org>.
mariofusco merged PR #5941:
URL: https://github.com/apache/incubator-kie-drools/pull/5941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org