[GitHub] sergeykolychev commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

[GitBox <gi...@apache.org>]

sergeykolychev commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.
URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r163720464
 
 

 ##########
 File path: perl-package/AI-MXNet/lib/AI/MXNet/Profiler.pm
 ##########
 @@ -37,18 +37,23 @@ use AI::MXNet::Function::Parameters;
 
     Parameters
     ----------
-    mode : string, optional
-        Indicting whether to enable the profiler, can
-        be 'symbolic' or 'all'. Default is `symbolic`.
-    filename : string, optional
-        The name of output trace file. Default is
-        'profile.json'.
+    kwargs : hash ref
+        Indicates configuration parameters with key/value pairs, listed below
+          profile_symbolic : boolean, whether to profile symbolic operators
+          profile_imperative : boolean, whether to profile imperative operators
+          profile_memory : boolean, whether to profile memory usage
+          profile_api : boolean, whether to profile the C API
+          file_name : string, output file for profile data
+          continuous_dump : boolean, whether to periodically dump profiling data to file
+          dump_period : float, seconds between profile data dumps
 =cut
 
-method profiler_set_config(ProfilerMode $mode='symbolic', Str $filename='profile.json')
+method profiler_set_config(HashRef[Str]:$kwargs)
 {
-    my %mode2int = qw/symbolic 0 all 1/;
-    check_call(AI::MXNet::SetProfilerConfig($mode2int{ $mode }, $filename));
+    my $keys = keys(%{ $kwargs });
 
 Review comment:
   @cjolivier01 
   This pull fixes perl usage, thanks!
   https://github.com/cjolivier01/mxnet/pull/1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services