You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/02/16 14:41:19 UTC
[jira] [Commented] (LUCENE-5044) wasted work in
AllGroupHeadsCollectorTest.arrayContains()
[ https://issues.apache.org/jira/browse/LUCENE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902715#comment-13902715 ]
ASF GitHub Bot commented on LUCENE-5044:
----------------------------------------
Github user PaulElschot commented on the pull request:
https://github.com/apache/lucene-solr/pull/24#issuecomment-35196892
Closed because of some conficts after LUCENE-5044.
> wasted work in AllGroupHeadsCollectorTest.arrayContains()
> ---------------------------------------------------------
>
> Key: LUCENE-5044
> URL: https://issues.apache.org/jira/browse/LUCENE-5044
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.3
> Environment: any
> Reporter: Adrian Nistor
> Priority: Minor
> Labels: patch, performance
> Fix For: 4.4, 5.0
>
> Attachments: patch.diff, patchAll.diff
>
>
> The problem appears in version 4.3.0 and in revision 1490286. I
> attached a one-line patch that fixes it.
> In method "AllGroupHeadsCollectorTest.arrayContains", the loop over
> "actual" should break immediately after "found" is set to "true". All
> the iterations after "found" is set to "true" do not perform any
> useful work, at best they just set "found" again to "true".
> Method "processWord" in class "CapitalizationFilter" has a similar
> loop (over "prefix"), and this loop breaks immediately after "match"
> is set to "false", just like in the proposed patch. Other methods
> (e.g., "Step.apply", "JapaneseTokenizer.computePenalty",
> "CompressingStoredFieldsWriter.saveInts", "FieldQuery.checkOverlap")
> also have similar loops with similar breaks, just like in the proposed
> patch.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org