You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "rmuir (via GitHub)" <gi...@apache.org> on 2023/09/22 03:32:58 UTC
[GitHub] [lucene] rmuir opened a new pull request, #12583: Fix hidden range embedded in UAX29URLEmail grammar
rmuir opened a new pull request, #12583:
URL: https://github.com/apache/lucene/pull/12583
TLDR: The dash needed escaping!
See #12561 for an explanation of the issue. Actually there were TODOs already in existing tests.
Closes #12561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #12583: Fix hidden range embedded in UAX29URLEmail grammar
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on code in PR #12583:
URL: https://github.com/apache/lucene/pull/12583#discussion_r1334328967
##########
lucene/analysis/common/src/test/org/apache/lucene/analysis/email/TestUAX29URLEmailAnalyzer.java:
##########
@@ -433,9 +433,9 @@ public void testMailtoSchemeEmails() throws Exception {
new String[] {
"mailto",
"persona@example.com",
- // TODO: recognize ',' address delimiter. Also, see examples of ';' delimiter use at:
+ // Also, see examples of ';' delimiter use at:
Review Comment:
yeah i don't know, I just tried to preserve these comments, and there are other similar TODO in the test. Especially this one: https://github.com/apache/lucene/blob/53ba27a63be6849d5383b8bfc6d1508dd7b66f0c/lucene/analysis/common/src/test/org/apache/lucene/analysis/email/TestUAX29URLEmailAnalyzer.java#L428C8-L428C96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] eraneverlaw commented on a diff in pull request #12583: Fix hidden range embedded in UAX29URLEmail grammar
Posted by "eraneverlaw (via GitHub)" <gi...@apache.org>.
eraneverlaw commented on code in PR #12583:
URL: https://github.com/apache/lucene/pull/12583#discussion_r1333932344
##########
lucene/analysis/common/src/test/org/apache/lucene/analysis/email/TestUAX29URLEmailAnalyzer.java:
##########
@@ -433,9 +433,9 @@ public void testMailtoSchemeEmails() throws Exception {
new String[] {
"mailto",
"persona@example.com",
- // TODO: recognize ',' address delimiter. Also, see examples of ';' delimiter use at:
+ // Also, see examples of ';' delimiter use at:
Review Comment:
Not sure what this comment means? Semicolon works as a delimiter.
Also, interesting that `?cc=personC@example.com` is supposedly a legal email address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix hidden range embedded in UAX29URLEmail grammar [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12583:
URL: https://github.com/apache/lucene/pull/12583#issuecomment-1880901201
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix hidden range embedded in UAX29URLEmail grammar [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12583:
URL: https://github.com/apache/lucene/pull/12583#issuecomment-3413342745
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix hidden range embedded in UAX29URLEmail grammar [lucene]
Posted by "ztravis (via GitHub)" <gi...@apache.org>.
ztravis commented on PR #12583:
URL: https://github.com/apache/lucene/pull/12583#issuecomment-3730662867
It would be great to fix this bug!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix hidden range embedded in UAX29URLEmail grammar [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir merged PR #12583:
URL: https://github.com/apache/lucene/pull/12583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org