You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/09/05 22:40:19 UTC
[GitHub] activemq-artemis pull request #2295: ARTEMIS-2076 Can't change queue filter ...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2295
ARTEMIS-2076 Can't change queue filter between restarts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2076
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2295
----
commit 92d43878e338efa59bd33bd93b2593d771c8a422
Author: Justin Bertram <jb...@...>
Date: 2018-09-05T18:48:42Z
ARTEMIS-2076 Can't change queue filter between restarts
----
---
[GitHub] activemq-artemis pull request #2295: ARTEMIS-2076 Can't change queue filter ...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2295#discussion_r215514830
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -2718,7 +2715,7 @@ private void undeployAddressesAndQueueNotInConfiguration(Configuration configura
removeAddressInfo(addressName, null);
} else if (addressSettings.getConfigDeleteQueues() == DeletionPolicy.FORCE) {
for (Queue queue : listConfiguredQueues(addressName)) {
- if (!queuesInConfig.contains(queue.getRoutingType().toString() + queue.getName().toString())) {
+ if (!queuesInConfig.contains(CoreQueueConfiguration.getCoreQueueConfiguration(queue).hashCode())) {
--- End diff --
Hash code is not safe unique. Should keep the equals on name
---
[GitHub] activemq-artemis pull request #2295: ARTEMIS-2076 Can't change queue filter ...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2295
---
[GitHub] activemq-artemis issue #2295: ARTEMIS-2076 Can't change queue filter between...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2295
This should just be updated like other values can on the queue via updateQueue in ActiveMQServer
---
[GitHub] activemq-artemis issue #2295: ARTEMIS-2076 Can't change queue filter between...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2295
Ive raised a PR https://github.com/apache/activemq-artemis/pull/2296 doing it via the updateQueue method as other updates are done, so its more inline and avoids being destructive. I have taken the same tests you had on this PR.
---