You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by huafengw <gi...@git.apache.org> on 2016/10/14 05:08:48 UTC
[GitHub] incubator-gearpump pull request #98: [GEARPUMP-224] merge gearpump-daemon to...
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/98
[GEARPUMP-224] merge gearpump-daemon to gearpump-core
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator-gearpump merge
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit ef7525c776a898ca52f4b8edf580337b793f35b5
Author: huafengw <fv...@gmail.com>
Date: 2016-10-14T04:41:43Z
[GEARPUMP-224] merge gearpump-daemon to gearpump-core
commit 73716a714e4170328dc5eeedf27670b15250921f
Author: huafengw <fv...@gmail.com>
Date: 2016-10-14T04:43:10Z
minor
commit 9c16b0dc7a521bb76053d8472337bfa13bd2c265
Author: huafengw <fv...@gmail.com>
Date: 2016-10-14T04:48:31Z
minor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #98: [GEARPUMP-224] merge gearpump-daemon to gearpu...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/98
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #98: [GEARPUMP-224] merge gearpump-daemon to...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/98#discussion_r83405410
--- Diff: project/Pack.scala ---
@@ -24,7 +24,6 @@ import xerial.sbt.Pack._
object Pack extends sbt.Build {
val daemonClassPath = Seq(
--- End diff --
suggestion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #98: [GEARPUMP-224] merge gearpump-daemon to...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/98#discussion_r83404467
--- Diff: project/Pack.scala ---
@@ -24,7 +24,6 @@ import xerial.sbt.Pack._
object Pack extends sbt.Build {
val daemonClassPath = Seq(
--- End diff --
shall we rename this classpath ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #98: [GEARPUMP-224] merge gearpump-daemon to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #98: [GEARPUMP-224] merge gearpump-daemon to gearpu...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/98
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/98?src=pr) is 72.20% (diff: 100%)
> Merging [#98](https://codecov.io/gh/apache/incubator-gearpump/pull/98?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **3.16%**
```diff
@@ master #98 diff @@
==========================================
Files 186 186
Lines 5985 5984 -1
Methods 5463 5462 -1
Messages 0 0
Branches 522 522
==========================================
+ Hits 4132 4321 +189
+ Misses 1853 1663 -190
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [a01809b...9c16b0d](https://codecov.io/gh/apache/incubator-gearpump/compare/a01809b2588a5dd1038b7afa8dca5148729e634c...9c16b0dc7a521bb76053d8472337bfa13bd2c265?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---