You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/03/19 14:22:14 UTC
[GitHub] [qpid-proton-j] conniey opened a new pull request #37: Adding
automatic module name entry.
conniey opened a new pull request #37: Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37
* Adds an Automatic-Module-Name to the MANIFEST.MF so it can be consumed by JDK 9+ libraries without warnings.
* Fixes issue: https://issues.apache.org/jira/browse/PROTON-2158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] JonathanGiles commented on issue #37: Adding
automatic module name entry.
Posted by GitBox <gi...@apache.org>.
JonathanGiles commented on issue #37: Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-602939738
@gemmellr Who is best placed to review this and consider merging it? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] gemmellr commented on issue #37: PROTON-2158 Adding
automatic module name entry.
Posted by GitBox <gi...@apache.org>.
gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-605201737
I had a look, and the module name addition itself seems fine, but I want to look into some odd behaviour around other manifest entries that get added after the change (yet on other pre-existing config seem like they should have been added previously) as well before putting the change in.
Can I also ask why you did the override on the parent managed jar plugin version? Its obviously a little newer, but was there a specific reason to need to use it? If not I'd perhaps suggest removing that and just sticking to the managed version for simplicity and consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] gemmellr commented on issue #37: PROTON-2158 Adding
automatic module name entry.
Posted by GitBox <gi...@apache.org>.
gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-606591003
It isnt the bundle plugin package additions, those are indeed expected, but rather it was some other additions about implementation and specification that dont seem to have been there before but are afterwards, and yet given existing parent config seem like perhaps they should have been before also. I was off yesterday and so still need to look into this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] conniey commented on issue #37: PROTON-2158 Adding
automatic module name entry.
Posted by GitBox <gi...@apache.org>.
conniey commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-606073224
> Can I also ask why you did the override on the parent managed jar plugin version?
No reason to use this version. I removed it.
> I want to look into some odd behaviour around other manifest entries that get added after the change
I'm not sure why they didn't show up when built from master, but the entries appear in previous versions of proton-j. :( I only know enough about maven-bundle-plugin to execute `bundle:bundle`. Looking at the manifest instructions, it looks like we did expect all those `Export-Package` entries.
https://github.com/apache/qpid-proton-j/blob/master/pom.xml#L100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] conniey commented on issue #37: PROTON-2158 Adding
automatic module name entry.
Posted by GitBox <gi...@apache.org>.
conniey commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-604723979
> For future, please add the JIRA key reference to the PR title and commit log as that way the JIRA
Thanks for letting me know. :) I'll do that in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] asfgit closed pull request #37: PROTON-2158 Adding
automatic module name entry.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] gemmellr commented on issue #37: PROTON-2158 Adding
automatic module name entry.
Posted by GitBox <gi...@apache.org>.
gemmellr commented on issue #37: PROTON-2158 Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-606663536
I've pushed your changes in https://github.com/apache/qpid-proton-j/commit/20c9943086678159d3776ebab03516eb11ed0f4a and added a further change in https://github.com/apache/qpid-proton-j/commit/02998b382967b997ac86a6b1ea2d507bfd9a862f to address the other entries being added.
(The Apache parent pom has dependencyManagement with configuration for the maven jar plugin, which isnt picked up by the bundle plugin when used due to 'bundle' packaging type... unless also adding an explicit jar plugin config as your change did, even though the bundle plugin is still used instead of the jar plugin. Odd.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton-j] gemmellr commented on issue #37: Adding automatic
module name entry.
Posted by GitBox <gi...@apache.org>.
gemmellr commented on issue #37: Adding automatic module name entry.
URL: https://github.com/apache/qpid-proton-j/pull/37#issuecomment-604578237
For future, please add the JIRA key reference to the PR title and commit log as that way the JIRA gets updated when PRs are opened, commented on, commits are pushed, etc. See prior PRs or commits for examples.
> @gemmellr Who is best placed to review this and consider merging it? Thanks.
Someone not off on holiday or sick, or more annoyingly both together as happened :) I'll try to look soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org