You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 03:35:54 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new issue #372: reduce usage of `IntoIterator- ` in logical plan builder window fn
Jimexist opened a new issue #372:
URL: https://github.com/apache/arrow-datafusion/issues/372
I am not sure we should use `IntoIterator<Item = Expr>` for every field with 6 fields. This will produce a version of the compiled function for every combination, which IMO adds an unnecessary compile time and binary size.
`IntoIterator` is more relevant when we want to avoid an extra allocation; these are very small vectors.
_Originally posted by @jorgecarleitao in https://github.com/apache/arrow-datafusion/pull/334#discussion_r636596927_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist closed issue #372: reduce usage of `IntoIterator- ` in logical plan builder window fn
Posted by GitBox <gi...@apache.org>.
Jimexist closed issue #372:
URL: https://github.com/apache/arrow-datafusion/issues/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org