You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/13 04:06:12 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1283: fix: omit taobao mirror
juzhiyuan opened a new pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
fix #1223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759197160
not sure, I need some time to work on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759196428
What happened to the lint...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759196407
/lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759282765
big PR, please confirm @liuxiran @LiteSun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759196482
https://github.com/apache/apisix-dashboard/pull/1283/checks?check_run_id=1692687432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis merged pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759192384
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=h1) Report
> Merging [#1283](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=desc) (51e6d52) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/ecfef5b63247ca13cac8280201d423dd52b98036?el=desc) (ecfef5b) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
Coverage 42.39% 42.39%
=======================================
Files 31 31
Lines 1932 1932
=======================================
Hits 819 819
Misses 1002 1002
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=footer). Last update [ecfef5b...51e6d52](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759283522
@membphis Those changes are generated to use the official CDN instead of the Taobao mirror.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759197008
> What happened to the lint...
does the default config of lint changed together with the dependences?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1283: fix: omit taobao mirror
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1283:
URL: https://github.com/apache/apisix-dashboard/pull/1283#issuecomment-759192384
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=h1) Report
> Merging [#1283](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=desc) (47496f2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4cb07c334b0061ec814258910bee029724f3b7f3?el=desc) (4cb07c3) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
Coverage 42.44% 42.44%
=======================================
Files 31 31
Lines 1932 1932
=======================================
Hits 820 820
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=footer). Last update [4cb07c3...47496f2](https://codecov.io/gh/apache/apisix-dashboard/pull/1283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org