You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2010/10/23 18:53:51 UTC
svn commit: r1026648 -
/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/AbstractBookmarkableMapper.java
Author: mgrigorov
Date: Sat Oct 23 16:53:51 2010
New Revision: 1026648
URL: http://svn.apache.org/viewvc?rev=1026648&view=rev
Log:
Findbugs warnings: .../wicket/src/main/java/org/apache/wicket/request/mapper/AbstractBookmarkableMapper.java:169 Possible null pointer dereference of componentInfo
Make check for 'componentInfo != null' before using it.
Modified:
wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/AbstractBookmarkableMapper.java
Modified: wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/AbstractBookmarkableMapper.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/AbstractBookmarkableMapper.java?rev=1026648&r1=1026647&r2=1026648&view=diff
==============================================================================
--- wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/AbstractBookmarkableMapper.java (original)
+++ wicket/trunk/wicket/src/main/java/org/apache/wicket/request/mapper/AbstractBookmarkableMapper.java Sat Oct 23 16:53:51 2010
@@ -165,9 +165,14 @@ public abstract class AbstractBookmarkab
{
PageInfo pageInfo = pageComponentInfo.getPageInfo();
ComponentInfo componentInfo = pageComponentInfo.getComponentInfo();
- Integer renderCount = componentInfo != null ? componentInfo.getRenderCount() : null;
+ Integer renderCount = null;
+ RequestListenerInterface listenerInterface = null;
- RequestListenerInterface listenerInterface = requestListenerInterfaceFromString(componentInfo.getListenerInterface());
+ if (componentInfo != null)
+ {
+ renderCount = componentInfo.getRenderCount();
+ listenerInterface = requestListenerInterfaceFromString(componentInfo.getListenerInterface());
+ }
if (listenerInterface != null)
{
@@ -183,8 +188,16 @@ public abstract class AbstractBookmarkab
{
if (logger.isWarnEnabled())
{
- logger.warn("Unknown listener interface '" + componentInfo.getListenerInterface() +
- "'");
+ if (componentInfo != null)
+ {
+ logger.warn("Unknown listener interface '{}'",
+ componentInfo.getListenerInterface());
+ }
+ else
+ {
+ logger.warn("Cannot extract the listener interface for PageComponentInfo: '{}'" +
+ pageComponentInfo);
+ }
}
return null;
}