You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Aaron Bannert <aa...@clove.org> on 2001/09/16 02:13:03 UTC

Re: cvs commit: apr/test testlockperf.c

On Sat, Sep 15, 2001 at 05:23:55AM -0000, rbb@apache.org wrote:
> rbb         01/09/14 22:23:55
> 
>   Modified:    test     testlockperf.c
>   Log:
>   Protect including a header file that doesn't exist on Windows
>   
>   Revision  Changes    Path
>   1.2       +2 -0      apr/test/testlockperf.c
>   
>   Index: testlockperf.c
>   ===================================================================
>   RCS file: /home/cvs/apr/test/testlockperf.c,v
>   retrieving revision 1.1
>   retrieving revision 1.2
>   diff -u -r1.1 -r1.2
>   --- testlockperf.c	2001/09/10 15:47:25	1.1
>   +++ testlockperf.c	2001/09/15 05:23:55	1.2
>   @@ -64,7 +64,9 @@
>    #include <stdio.h>
>    #include <stdlib.h>
>    #include "test_apr.h"
>   +#ifdef HAVE_SYS_TIME_h
>    #include <sys/time.h> /* replace me with apr_time.h */
>   +#endif
>    
>    #if !APR_HAS_THREADS
>    int main(void)
>   

Actually, that header was left over from when I was using gettimeofday(),
and can be safely removed:

[I know you really didn't need a patch to illustrate this. ;) ]

-aaron

Index: testlockperf.c
===================================================================
RCS file: /home/cvspublic/apr/test/testlockperf.c,v
retrieving revision 1.2
diff -u -r1.2 testlockperf.c
--- testlockperf.c	2001/09/15 05:23:55	1.2
+++ testlockperf.c	2001/09/16 00:06:05
@@ -64,9 +64,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include "test_apr.h"
-#ifdef HAVE_SYS_TIME_h
-#include <sys/time.h> /* replace me with apr_time.h */
-#endif
 
 #if !APR_HAS_THREADS
 int main(void)

Re: cvs commit: apr/test testlockperf.c

Posted by Cliff Woolley <cl...@yahoo.com>.
On Sat, 15 Sep 2001, Aaron Bannert wrote:

> >   +#ifdef HAVE_SYS_TIME_h
> >    #include <sys/time.h> /* replace me with apr_time.h */
> >   +#endif
> >
> >    #if !APR_HAS_THREADS
> >    int main(void)
> >
>
> Actually, that header was left over from when I was using gettimeofday(),
> and can be safely removed:

And the #ifdef never woulda worked anyway because the _h isn't
capitalized.

> [I know you really didn't need a patch to illustrate this. ;) ]

Nope.  But thanks anyhow.  :)

Committed.  [I know you really didn't need me to tell you that for you to
know it was done. ;) ]

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA