You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Nissim Shiman (Jira)" <ji...@apache.org> on 2020/02/10 23:37:00 UTC

[jira] [Comment Edited] (NIFI-7123) onPropertyModified() is called on nifi start up even when properties have never been modified

    [ https://issues.apache.org/jira/browse/NIFI-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034027#comment-17034027 ] 

Nissim Shiman edited comment on NIFI-7123 at 2/10/20 11:36 PM:
---------------------------------------------------------------

We were seeing the onPropertyModified() being run when we hadn't changed any properties, so I thought it was an issue.

I guess it can be a feature as opposed to a bug, though.

Maybe the doc could be updated to reflect this :
 [https://github.com/apache/nifi/blob/master/nifi-api/src/main/java/org/apache/nifi/components/ConfigurableComponent.java#L55]  (i.e. take out the part where it is called for "each property that is not set to the default value" as it is called even when the property is still the default value)

I'm OK if the ticket is closed


was (Author: nissim shiman):
We were seeing the onPropertyModified() being run when we hadn't changed any properties, so I thought it was an issue.

I guess it can be a feature as opposed to a bug, though.

Maybe the doc could be updated to reflect this :
[https://github.com/apache/nifi/blob/master/nifi-api/src/main/java/org/apache/nifi/components/ConfigurableComponent.java#L55]  (i.e. take out the part where it is called for "each property that is not set to the default value" as it is called even when the property is still the default value)

> onPropertyModified() is called on nifi start up even when properties have never been modified
> ---------------------------------------------------------------------------------------------
>
>                 Key: NIFI-7123
>                 URL: https://issues.apache.org/jira/browse/NIFI-7123
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Nissim Shiman
>            Assignee: Nissim Shiman
>            Priority: Major
>
> Processors and Controller Services inherit the onPropertyModified() method from ConfigurableComponent. java [1]
> This method is called when nifi starts for all processors and controller services, even for properties that are set to their defaults (i.e. have never been modified).
> [1]  https://github.com/apache/nifi/blob/master/nifi-api/src/main/java/org/apache/nifi/components/ConfigurableComponent.java#L68



--
This message was sent by Atlassian Jira
(v8.3.4#803005)