You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Viacheslav Blinov (Jira)" <ji...@apache.org> on 2024/03/06 15:56:00 UTC

[jira] [Created] (IGNITE-21695) PageHandler: useless control flow

Viacheslav Blinov created IGNITE-21695:
------------------------------------------

             Summary: PageHandler: useless control flow
                 Key: IGNITE-21695
                 URL: https://issues.apache.org/jira/browse/IGNITE-21695
             Project: Ignite
          Issue Type: Bug
            Reporter: Viacheslav Blinov


Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.ignite.internal.tx.impl.HeapLockManager$WaiterImpl.recalculate() makes inefficient use of keySet iterator instead of entrySet iterator  At HeapLockManager.java:[line 815]
M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.ignite.internal.tx.impl.HeapUnboundedLockManager$WaiterImpl.recalculate() makes inefficient use of keySet iterator instead of entrySet iterator  At HeapUnboundedLockManager.java:[line 632] {noformat}
This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.

Investigate whenever this is a false-positive and we should suppress it, or we should make a proper fix.
At the result of investigation corresponding TODO should be removed in spotbugs-excludes.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)