You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2017/09/07 06:53:44 UTC
Review Request 62149: ATLAS-2111 : UI: Select query is not able to
render the search table in Advance search
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62149/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2111
https://issues.apache.org/jira/browse/ATLAS-2111
Repository: atlas
Description
-------
Steps to reproduce.
* Run quick_start and generate few test data.
* Go to advance search selection
* Now search for the DB where name="Reporting" select name, owner.
* Table will show empty even though API has data.
Diffs
-----
dashboardv2/public/js/collection/VSearchList.js 0a7b713
dashboardv2/public/js/views/search/SearchResultLayoutView.js 970d6a3
Diff: https://reviews.apache.org/r/62149/diff/1/
Testing
-------
Tested DB where name="Reporting" select name, owner querys its working as expected.
Thanks,
keval bhatt
Re: Review Request 62149: ATLAS-2111 : UI: Select query is not able to
render the search table in Advance search
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62149/#review185143
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Sept. 7, 2017, 6:53 a.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62149/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 6:53 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2111
> https://issues.apache.org/jira/browse/ATLAS-2111
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Steps to reproduce.
>
> * Run quick_start and generate few test data.
> * Go to advance search selection
> * Now search for the DB where name="Reporting" select name, owner.
> * Table will show empty even though API has data.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/collection/VSearchList.js 0a7b713
> dashboardv2/public/js/views/search/SearchResultLayoutView.js 970d6a3
>
>
> Diff: https://reviews.apache.org/r/62149/diff/1/
>
>
> Testing
> -------
>
> Tested DB where name="Reporting" select name, owner querys its working as expected.
>
>
> Thanks,
>
> keval bhatt
>
>
Re: Review Request 62149: ATLAS-2111 : UI: Select query is not able to
render the search table in Advance search
Posted by keval bhatt <kb...@apache.org>.
> On Sept. 12, 2017, 11:54 p.m., Madhan Neethiraj wrote:
> > Couple of things to look into:
> > - results page has fixed columns 'Name, Owner, Description, Type, Tags'. Instead, it should show the columns for the attributes retrieved in the result. For the example given in the review description, the result page should render 2 columns "Name", "Owner"
> > - The result doesn't include entity-guid for each row. So, UI shouldn't render the "+" button on 'Tags' column, as tags can't be added without knowing entity GUID. In fact, 'Tags' column shouldn't be rendered at all, as the result wouldn't include tags
> >
> > Also, the patch applies only on branch-0.8 and not the master. Please update the review with the branch information.
Updated patch will render selected columns only.
- keval
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62149/#review185247
-----------------------------------------------------------
On Sept. 28, 2017, 6:03 a.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62149/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 6:03 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2111
> https://issues.apache.org/jira/browse/ATLAS-2111
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Steps to reproduce.
>
> * Run quick_start and generate few test data.
> * Go to advance search selection
> * Now search for the DB where name="Reporting" select name, owner.
> * Table will show empty even though API has data.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/collection/VSearchList.js 0a7b713
> dashboardv2/public/js/views/search/SearchResultLayoutView.js fbcd352
>
>
> Diff: https://reviews.apache.org/r/62149/diff/2/
>
>
> Testing
> -------
>
> Tested DB where name="Reporting" select name, owner querys its working as expected.
>
>
> Thanks,
>
> keval bhatt
>
>
Re: Review Request 62149: ATLAS-2111 : UI: Select query is not able to
render the search table in Advance search
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62149/#review185247
-----------------------------------------------------------
Couple of things to look into:
- results page has fixed columns 'Name, Owner, Description, Type, Tags'. Instead, it should show the columns for the attributes retrieved in the result. For the example given in the review description, the result page should render 2 columns "Name", "Owner"
- The result doesn't include entity-guid for each row. So, UI shouldn't render the "+" button on 'Tags' column, as tags can't be added without knowing entity GUID. In fact, 'Tags' column shouldn't be rendered at all, as the result wouldn't include tags
Also, the patch applies only on branch-0.8 and not the master. Please update the review with the branch information.
- Madhan Neethiraj
On Sept. 7, 2017, 6:53 a.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62149/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2017, 6:53 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2111
> https://issues.apache.org/jira/browse/ATLAS-2111
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Steps to reproduce.
>
> * Run quick_start and generate few test data.
> * Go to advance search selection
> * Now search for the DB where name="Reporting" select name, owner.
> * Table will show empty even though API has data.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/collection/VSearchList.js 0a7b713
> dashboardv2/public/js/views/search/SearchResultLayoutView.js 970d6a3
>
>
> Diff: https://reviews.apache.org/r/62149/diff/1/
>
>
> Testing
> -------
>
> Tested DB where name="Reporting" select name, owner querys its working as expected.
>
>
> Thanks,
>
> keval bhatt
>
>
Re: Review Request 62149: ATLAS-2111 : UI: Select query is not able to
render the search table in Advance search
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62149/#review186646
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 28, 2017, 6:03 a.m., keval bhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62149/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2017, 6:03 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2111
> https://issues.apache.org/jira/browse/ATLAS-2111
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Steps to reproduce.
>
> * Run quick_start and generate few test data.
> * Go to advance search selection
> * Now search for the DB where name="Reporting" select name, owner.
> * Table will show empty even though API has data.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/collection/VSearchList.js 0a7b713
> dashboardv2/public/js/views/search/SearchResultLayoutView.js fbcd352
>
>
> Diff: https://reviews.apache.org/r/62149/diff/2/
>
>
> Testing
> -------
>
> Tested DB where name="Reporting" select name, owner querys its working as expected.
>
>
> Thanks,
>
> keval bhatt
>
>
Re: Review Request 62149: ATLAS-2111 : UI: Select query is not able to
render the search table in Advance search
Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62149/
-----------------------------------------------------------
(Updated Sept. 28, 2017, 6:03 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Based on selected columns UI will render columns
Bugs: ATLAS-2111
https://issues.apache.org/jira/browse/ATLAS-2111
Repository: atlas
Description
-------
Steps to reproduce.
* Run quick_start and generate few test data.
* Go to advance search selection
* Now search for the DB where name="Reporting" select name, owner.
* Table will show empty even though API has data.
Diffs (updated)
-----
dashboardv2/public/js/collection/VSearchList.js 0a7b713
dashboardv2/public/js/views/search/SearchResultLayoutView.js fbcd352
Diff: https://reviews.apache.org/r/62149/diff/2/
Changes: https://reviews.apache.org/r/62149/diff/1-2/
Testing
-------
Tested DB where name="Reporting" select name, owner querys its working as expected.
Thanks,
keval bhatt