You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/15 07:52:58 UTC

[GitHub] [flink] snuyanzin commented on a diff in pull request #20746: [FLINK-28893][table] Add built-in conv function.

snuyanzin commented on code in PR #20746:
URL: https://github.com/apache/flink/pull/20746#discussion_r1022446011


##########
docs/data/sql_functions.yml:
##########
@@ -228,6 +228,13 @@ arithmetic:
   - sql: UUID()
     table: uuid()
     description: Returns an UUID (Universally Unique Identifier) string (e.g., "3d3c68f7-f608-473f-b60c-b0c44ad4cc4e") according to RFC 4122 type 4 (pseudo randomly generated) UUID. The UUID is generated using a cryptographically strong pseudo random number generator.
+  - sql: |
+      CONV(numeric, numeric1, numeric2)
+      CONV(string, numeric1, numeric2)

Review Comment:
   What happens if input will contain number `Long.MAX_VALUE + 5` ?
   Doc says nothing about it however there are some checks in the code for `Long.MAX_VALUE`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org