You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/23 21:37:10 UTC
[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18783: remove other language bindings section from website api page
ys2843 opened a new pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783
## Description ##
Since other language bindings are deprecated in MXNet 2.0, this PR removes the corresponding parts from website.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
### Changes ###
- [ ] Remove "other bindings" block from `/api` page.
## Comments ##
- Preview: pending
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] aaronmarkham commented on a change in pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on a change in pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#discussion_r461234484
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
+ The language bindings of MXNet 1.x were deleted in 2.x due to some C APIs being deprecated and the bindings did rely on the deprecated APIs.
Review comment:
```suggestion
The Clojure, Java, Julia, R, and Scala language bindings of MXNet v1.x were removed in v2.x due to some C APIs being deprecated and the bindings rely on the deprecated APIs. You can still use these language bindings in v1.x.
```
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
+ The language bindings of MXNet 1.x were deleted in 2.x due to some C APIs being deprecated and the bindings did rely on the deprecated APIs.
+ Given that MXNet has C APIs and other language bindings can be added. Your contribution is welcome.
Review comment:
```suggestion
MXNet's new C APIs in v2.x can be used to reestablish your preferred language binding. Your contribution is welcome!
```
Can you double check that folks should be using the CPP API instead? Previously this was always a debate since the C API was supposed to be internal only.
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
Review comment:
```suggestion
<h4>Language Bindings Call for Contributions</h4>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-664740213
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-663709911
No, it has only been announced in https://github.com/apache/incubator-mxnet/issues/16167. It would be good to add a statement ot the website regarding "call for contributions"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on a change in pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
ys2843 commented on a change in pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#discussion_r461786494
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
+ The Clojure, Java, Julia, R, and Scala language bindings of MXNet v1.x were removed in v2.x due to some C APIs being deprecated and the bindings rely on the deprecated APIs. You can still use these language bindings in v1.x.
Review comment:
Done, added the reference github issue: https://github.com/apache/incubator-mxnet/issues/17676
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
+ The Clojure, Java, Julia, R, and Scala language bindings of MXNet v1.x were removed in v2.x due to some C APIs being deprecated and the bindings rely on the deprecated APIs. You can still use these language bindings in v1.x.
Review comment:
Done, add hyperlink to latest 1.x website
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-664690296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-663257157
@mxnet-label-bot update [Website, pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-663257157
@mxnet-label-bot add [Website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#discussion_r461753773
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
+ The Clojure, Java, Julia, R, and Scala language bindings of MXNet v1.x were removed in v2.x due to some C APIs being deprecated and the bindings rely on the deprecated APIs. You can still use these language bindings in v1.x.
Review comment:
We should create an issue, if not already exists, with list of C APIs deprecated.
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
+ The Clojure, Java, Julia, R, and Scala language bindings of MXNet v1.x were removed in v2.x due to some C APIs being deprecated and the bindings rely on the deprecated APIs. You can still use these language bindings in v1.x.
Review comment:
and refer it here.
##########
File path: docs/static_site/src/pages/api/api.html
##########
@@ -123,26 +74,11 @@ <h4>Python-first API</h4>
{%- endfor -%}
<h2>Other Bindings</h2>
<div class="row">
-{%- for doc in page.docs -%}
- {%- if doc.tag != 'python' -%}
- <div class="col-4">
- <div class="docs-card">
- <div class="docs-logo-container">
- <img class="docs-logo-image" src="{{doc.icon | relative_url}}">
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.guide_link | relative_url}}"> <img src="{{'assets/img/compass.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Guide <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.tutorial_link | relative_url}}"> <img src="{{'assets/img/video-tutorial.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} Tutorials <span class="span-accented">›</span></a>
- </div>
- <div class="docs-action-btn">
- <a href="{{doc.api_link | relative_url}}"> <img src="{{'assets/img/api.svg' | relative_url}}" class="docs-logo-docs">{{doc.title}} API Reference <span class="span-accented">›</span></a>
- </div>
- </div>
+ <div class="language-binding-banner">
+ <h4>Call for Contribution</h4>
+ The Clojure, Java, Julia, R, and Scala language bindings of MXNet v1.x were removed in v2.x due to some C APIs being deprecated and the bindings rely on the deprecated APIs. You can still use these language bindings in v1.x.
Review comment:
should we hyperlink 1.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-663244870
Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, windows-cpu, website, edge, miscellaneous, centos-gpu, centos-cpu, sanity, windows-gpu, unix-cpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-664690296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] aaronmarkham merged pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
aaronmarkham merged pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18783: remove other language bindings section from website api page
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18783:
URL: https://github.com/apache/incubator-mxnet/pull/18783#issuecomment-663654386
> Looks fine, but shouldn't there be some mention of them - to ask for community contributions and have some kind of acknowledgement that they exist for older versions, but are not currently compatible with 2.0?
Good point. @leezu I was wondering if the removal of language bindings in MXNet 2.0 was mentioned to community when the docs were removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org