You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by yasserzamani <gi...@git.apache.org> on 2017/09/11 14:21:19 UTC
[GitHub] struts pull request #167: WW-4034 Allows to use custom JSONwriter
GitHub user yasserzamani opened a pull request:
https://github.com/apache/struts/pull/167
WW-4034 Allows to use custom JSONwriter
Wow! I really enjoyed this work! thanks to S2's nice design!
Just a small query about documenting it please. While documentations are in a middle of transition now and JSON plugin not transited for now, could I create a pull request on struts-site or I should wait for completion of transitions?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yasserzamani/struts WW-4034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #167
----
commit 39bdb99a116080a56242dc33303c4ab6d2b28f8f
Author: Yasser Zamani <ya...@live.com>
Date: 2017-09-11T13:39:32Z
WW-4034 Refactors and extracts interface from JSONWriter
commit 5bb472fa8585fddb38767dd4752a50cd5f51ff61
Author: Yasser Zamani <ya...@live.com>
Date: 2017-09-11T14:10:34Z
WW-4034 Allows to use custom JSONwriter
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #167: WW-4034 Allows to use custom JSONwriter
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/167
I will transit the plugin page and will let you know. Give me few days :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #167: WW-4034 Allows to use custom JSONwriter
Posted by yasserzamani <gi...@git.apache.org>.
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/167
Finished. I tested on heavy concurrent load using Servlet 3's async API several times. Before last commit, the response of some requests was mixed-up with others! But now all of them are right :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #167: WW-4034 Allows to use custom JSONwriter
Posted by yasserzamani <gi...@git.apache.org>.
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/167
Ouch! In #164 I refactored JSONWriter as a static member of JSONUtil. As I guessed, it fails to generate correct response in concurrent loads :(
Please give me a few time. I'm going to fix it here in this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts issue #167: WW-4034 Allows to use custom JSONwriter
Posted by yasserzamani <gi...@git.apache.org>.
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/167
I'm in no rush, I just wished to know. thanks for your works 👍
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org