You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/19 22:05:26 UTC
[GitHub] [incubator-nuttx] patacongo opened a new issue #1078: nxstyle: No error reported on long right hand comments
patacongo opened a new issue #1078:
URL: https://github.com/apache/incubator-nuttx/issues/1078
The following does not generate a long line error. I should, of course:
/****************************************************************************
* junk.c
****************************************************************************/
/****************************************************************************
* Included Files
****************************************************************************/
#include <stdint.h>
/****************************************************************************
* Private Types
****************************************************************************/
struct a_struct_s
{
uint8_t f; /* This is a very long line in a single, right-hand comment, No error is reported by nxstyle. */
};
/****************************************************************************
* Public Functions
****************************************************************************/
Related: Issue #652
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on issue #1078: nxstyle: No error reported on long right hand comments
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #1078:
URL: https://github.com/apache/incubator-nuttx/issues/1078#issuecomment-631110126
It is not recommended that this issue be fixed quickly. There are many header files, especially under `arch/ `that have long lines of this type that would then be reported. We can't afford that workload now.
There are a couple of places where this should be reported in `nxstyle.c`. One of them has already been fixed, but intentionally disabled for that reason:
2422 /* Check for long lines
2423 *
2424 * REVISIT: Long line checks suppressed on right hand comments
2425 * for now. This just prevents a large number of difficult-to-
2426 * fix complaints that we would have otherwise.
2427 */
2428
2429 if (m > g_maxline && !rhcomment)
2430 {
2431 if (g_file_type == C_SOURCE)
2432 {
2433 ERROR("Long line found", lineno, m);
2434 }
2435 else if (g_file_type == C_HEADER)
2436
2437 {
2438 WARN("Long line found", lineno, m);
2439 }
2440 }
2441 }
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org