[GitHub] [ignite] sergey-chugunov-1985 commented on a change in pull request #7835: IGNITE-13012 Make node connection checking rely on the configuration. Simplify node ping routine.

[GitBox <gi...@apache.org>]

sergey-chugunov-1985 commented on a change in pull request #7835:
URL: https://github.com/apache/ignite/pull/7835#discussion_r444162526



##########
File path: modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryImpl.java
##########
@@ -303,7 +303,7 @@ public int boundPort() throws IgniteSpiException {
     /**
      * @return connection check interval.
      */
-    public long connectionCheckInterval() {
+    long connectionCheckInterval() {

Review comment:
       We shouldn't reduce visibility of methods in public API. It is highly unlikely of course that there are users calling this method directly but this concealing of method is definitely a breaking change, it could be targeted only to major releases not a minor ones.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org