You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/18 06:42:06 UTC
[GitHub] [dubbo-go] ChangedenCZD opened a new pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
ChangedenCZD opened a new pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #1362
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85baf83) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.67%`.
> The diff coverage is `61.26%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.39% -2.68%
==========================================
Files 275 276 +1
Lines 13381 15955 +2574
==========================================
+ Hits 7771 8839 +1068
- Misses 4650 6175 +1525
+ Partials 960 941 -19
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-41.29%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `19.80% <28.57%> (+4.32%)` | :arrow_up: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...85baf83](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691742304
##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
"github.com/apache/dubbo-go/config"
)
+const (
+ TCP_READ_TIMEOUT_MIN_VALUE = time.Second * 1
+ TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5
Review comment:
tcp write timeout 默认值是 5s，但是 getty 同样是小于 1s 报 panic，最小值设置为 5s 的考虑是什么？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r692596687
##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
"github.com/apache/dubbo-go/config"
)
+const (
+ TCP_READ_TIMEOUT_MIN_VALUE = time.Second * 1
+ TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5
Review comment:
有道理
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r692049614
##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
"github.com/apache/dubbo-go/config"
)
+const (
+ TCP_READ_TIMEOUT_MIN_VALUE = time.Second * 1
+ TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5
Review comment:
默认值是5s不代表最小5s吧，你这个问题不是为了解决getty参数设置过小panic的问题么，关于那个issue的原因是小于1s导致panic。
getty 里有单测是可以找到设置 write timeout 为 3s 的 case。
因此我建议这里用 1s 会更合适。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-901587032
> 这类代码很多,可以考虑统一下，要么考虑下[url#GetParamDuration](https://github.com/apache/dubbo-go/blob/config-enhance/common/url.go#GetParamDuration)
功能不一致，且在1.5分支没找到对应代码
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691751786
##########
File path: remoting/getty/config.go
##########
@@ -179,6 +184,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min time.Duration, max *time.Duration) (time.Duration, error) {
+ result, err := time.ParseDuration(timeStr)
+ if err != nil {
+ return min, err
+ }
+ if max != nil && min > *max {
Review comment:
我考虑是函数内部处理好这些err，而不是交由调用方处理。
这个问题值得探讨。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41842cc) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.47%`.
> The diff coverage is `60.99%`.
> :exclamation: Current head 41842cc differs from pull request most recent head cc6c7b4. Consider uploading reports for the commit cc6c7b4 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.59% -2.48%
==========================================
Files 275 276 +1
Lines 13381 15954 +2573
==========================================
+ Hits 7771 8870 +1099
- Misses 4650 6141 +1491
+ Partials 960 943 -17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-41.29%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `19.00% <23.07%> (+3.52%)` | :arrow_up: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...cc6c7b4](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691749596
##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
"github.com/apache/dubbo-go/config"
)
+const (
+ TCP_READ_TIMEOUT_MIN_VALUE = time.Second * 1
+ TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5
Review comment:
因为默认配置以及struct中的default就是5s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691750532
##########
File path: remoting/getty/config.go
##########
@@ -179,6 +184,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min time.Duration, max *time.Duration) (time.Duration, error) {
+ result, err := time.ParseDuration(timeStr)
+ if err != nil {
+ return min, err
+ }
+ if max != nil && min > *max {
+ min, max = *max, &min
+ }
+ if result < min {
Review comment:
考虑到当前使用场景，min是必填的，所以从指针改为引用了，#1380 这个pr的第一个commit就是两者皆为指针
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691760145
##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
"github.com/apache/dubbo-go/config"
)
+const (
+ TCP_READ_TIMEOUT_MIN_VALUE = time.Second * 1
+ TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5
Review comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e77623) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.69%`.
> The diff coverage is `65.64%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.37% -2.70%
==========================================
Files 275 276 +1
Lines 13381 15948 +2567
==========================================
+ Hits 7771 8832 +1061
- Misses 4650 6178 +1528
+ Partials 960 938 -22
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <ø> (-41.29%)` | :arrow_down: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `20.21% <50.00%> (+4.73%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `70.29% <60.00%> (+0.97%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...5e77623](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41842cc) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.47%`.
> The diff coverage is `60.99%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.59% -2.48%
==========================================
Files 275 276 +1
Lines 13381 15954 +2573
==========================================
+ Hits 7771 8870 +1099
- Misses 4650 6141 +1491
+ Partials 960 943 -17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-41.29%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `19.00% <23.07%> (+3.52%)` | :arrow_up: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...41842cc](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691744257
##########
File path: remoting/getty/config.go
##########
@@ -179,6 +184,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min time.Duration, max *time.Duration) (time.Duration, error) {
+ result, err := time.ParseDuration(timeStr)
+ if err != nil {
+ return min, err
+ }
+ if max != nil && min > *max {
Review comment:
另外这一段替换是否有必要，方法参数名已经完全能够说明参数含义，如果从健壮性角度看 min 是否也得判空，而且感觉这段逻辑不太能起到保护作用，假如 max 传个比 min 小的 0.8s 啥的也容易出 panic。
个人建议可以直接返回 min>max 的 error 就好。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
cityiron commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r692690914
##########
File path: remoting/getty/config.go
##########
@@ -179,6 +184,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min *time.Duration, max *time.Duration) (time.Duration, error) {
+ result, err := time.ParseDuration(timeStr)
+ if err != nil {
+ return *min, err
+ }
+ if min != nil && max != nil && *min > *max { // swap
Review comment:
The semantics of the min and max parameters are not clear, I don't think swap is need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e77623) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.69%`.
> The diff coverage is `65.64%`.
> :exclamation: Current head 5e77623 differs from pull request most recent head 1e99454. Consider uploading reports for the commit 1e99454 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.37% -2.70%
==========================================
Files 275 276 +1
Lines 13381 15948 +2567
==========================================
+ Hits 7771 8832 +1061
- Misses 4650 6178 +1528
+ Partials 960 938 -22
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <ø> (-41.29%)` | :arrow_down: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `20.21% <50.00%> (+4.73%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `70.29% <60.00%> (+0.97%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...1e99454](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41842cc) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.47%`.
> The diff coverage is `60.99%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.59% -2.48%
==========================================
Files 275 276 +1
Lines 13381 15954 +2573
==========================================
+ Hits 7771 8870 +1099
- Misses 4650 6141 +1491
+ Partials 960 943 -17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-41.29%)` | :arrow_down: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `19.00% <23.07%> (+3.52%)` | :arrow_up: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...41842cc](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691757140
##########
File path: remoting/getty/config.go
##########
@@ -179,6 +184,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min time.Duration, max *time.Duration) (time.Duration, error) {
+ result, err := time.ParseDuration(timeStr)
+ if err != nil {
+ return min, err
+ }
+ if max != nil && min > *max {
Review comment:
@LaurenceLiZhixin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r692596687
##########
File path: remoting/getty/config.go
##########
@@ -29,6 +29,11 @@ import (
"github.com/apache/dubbo-go/config"
)
+const (
+ TCP_READ_TIMEOUT_MIN_VALUE = time.Second * 1
+ TCP_WRITE_TIMEOUT_MIN_VALUE = time.Second * 5
Review comment:
有道理，已调整
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc6c7b4) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.55%`.
> The diff coverage is `61.53%`.
> :exclamation: Current head cc6c7b4 differs from pull request most recent head 85baf83. Consider uploading reports for the commit 85baf83 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.52% -2.56%
==========================================
Files 275 276 +1
Lines 13381 15956 +2575
==========================================
+ Hits 7771 8859 +1088
- Misses 4650 6156 +1506
+ Partials 960 941 -19
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-41.29%)` | :arrow_down: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `20.58% <33.33%> (+5.11%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...85baf83](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc6c7b4) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.55%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.52% -2.56%
==========================================
Files 275 276 +1
Lines 13381 15956 +2575
==========================================
+ Hits 7771 8859 +1088
- Misses 4650 6156 +1506
+ Partials 960 941 -19
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (-41.29%)` | :arrow_down: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `20.58% <33.33%> (+5.11%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <58.33%> (+2.14%)` | :arrow_up: |
| ... and [295 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...cc6c7b4](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ce990a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.57%`.
> The diff coverage is `60.00%`.
> :exclamation: Current head 7ce990a differs from pull request most recent head 1e99454. Consider uploading reports for the commit 1e99454 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1388 +/- ##
==========================================
- Coverage 58.07% 55.49% -2.58%
==========================================
Files 275 276 +1
Lines 13381 15948 +2567
==========================================
+ Hits 7771 8851 +1080
- Misses 4650 6159 +1509
+ Partials 960 938 -22
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-27.16%)` | :arrow_down: |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `64.15% <0.00%> (+13.03%)` | :arrow_up: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
| [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
| [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
| ... and [308 more](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d2ddb7a...1e99454](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r691742697
##########
File path: remoting/getty/config.go
##########
@@ -179,6 +184,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min time.Duration, max *time.Duration) (time.Duration, error) {
+ result, err := time.ParseDuration(timeStr)
+ if err != nil {
+ return min, err
+ }
+ if max != nil && min > *max {
+ min, max = *max, &min
+ }
+ if result < min {
Review comment:
从方法名上看是将 timeStr 限定在 [min, max] 中，那 min 是不是应该和 max 一样判空。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org