You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/10 07:38:17 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new pull request, #969: Fix server cannot exit properly when enabling cluster mode
git-hulk opened a new pull request, #969:
URL: https://github.com/apache/incubator-kvrocks/pull/969
This closes #965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #969: Fix server cannot exit properly when enabling cluster mode
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #969:
URL: https://github.com/apache/incubator-kvrocks/pull/969#issuecomment-1274096734
Thanks all, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #969: Fix server cannot exit properly when enabling cluster mode
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #969:
URL: https://github.com/apache/incubator-kvrocks/pull/969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] caipengbo commented on a diff in pull request #969: Fix server cannot exit properly when enabling cluster mode
Posted by GitBox <gi...@apache.org>.
caipengbo commented on code in PR #969:
URL: https://github.com/apache/incubator-kvrocks/pull/969#discussion_r991768430
##########
src/slot_migrate.h:
##########
@@ -145,6 +145,13 @@ class SlotMigrate : public Redis::Database {
};
ParserState stat_ = ArrayLen;
+ enum ThreadState {
Review Comment:
`enum class` is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #969: Fix server cannot exit properly when enabling cluster mode
Posted by GitBox <gi...@apache.org>.
git-hulk commented on code in PR #969:
URL: https://github.com/apache/incubator-kvrocks/pull/969#discussion_r991793065
##########
src/slot_migrate.h:
##########
@@ -145,6 +145,13 @@ class SlotMigrate : public Redis::Database {
};
ParserState stat_ = ArrayLen;
+ enum ThreadState {
Review Comment:
Sure, it makes sense. Please take a look again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #969: Fix server cannot exit properly when enabling cluster mode
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #969:
URL: https://github.com/apache/incubator-kvrocks/pull/969#issuecomment-1272971520
Can review commits one by one, this PR also solves some typos and naming issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org