You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "TheR1sing3un (via GitHub)" <gi...@apache.org> on 2023/06/17 17:39:30 UTC

[PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

TheR1sing3un opened a new pull request, #4132:
URL: https://github.com/apache/eventmesh/pull/4132

   <!--
   ### Contribution Checklist
   
     - Name the pull request in the form "[ISSUE #XXXX] Title of the pull request", 
       where *XXXX* should be replaced by the actual issue number.
       Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
   
     - Fill out the template below to describe the changes contributed by the pull request. 
       That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue. 
       Please do not mix up code from multiple issues.
     
     - Each commit in the pull request should have a meaningful commit message.
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, 
       leaving only the filled out template below.
   
   (The sections below can be removed for hotfixes of typos)
   -->
   
   <!--
   (If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
   -->
   
   Fixes #4082 .
   
   ### Motivation
   
   *Explain the content here.*
   *Explain why you want to make the changes and what problem you're trying to solve.*
   
   
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1655276538

   > @TheR1sing3un The code is good, but the code structure of the project needs to be renamed and changed with reference to the existing structure
   
   Got it! I will update it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1612370293

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4132?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#4132](https://app.codecov.io/gh/apache/eventmesh/pull/4132?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6c8175e) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/1600c6bf1cbdb34de4bc3e9630898ab158c7af6f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1600c6b) will **decrease** coverage by `0.06%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 6c8175e differs from pull request most recent head 493c469. Consider uploading reports for the commit 493c469 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4132      +/-   ##
   ============================================
   - Coverage     16.93%   16.87%   -0.06%     
   + Complexity     1413     1412       -1     
   ============================================
     Files           589      593       +4     
     Lines         25786    25848      +62     
     Branches       2397     2384      -13     
   ============================================
   - Hits           4367     4362       -5     
   - Misses        20983    21050      +67     
     Partials        436      436              
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../eventmesh/source/connector/s3/S3SourceWorker.java](https://app.codecov.io/gh/apache/eventmesh/pull/4132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbm5lY3RvcnMvc291cmNlLWNvbm5lY3Rvci1zMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NvdXJjZS9jb25uZWN0b3IvczMvUzNTb3VyY2VXb3JrZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...sh/source/connector/s3/config/ConnectorConfig.java](https://app.codecov.io/gh/apache/eventmesh/pull/4132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbm5lY3RvcnMvc291cmNlLWNvbm5lY3Rvci1zMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NvdXJjZS9jb25uZWN0b3IvczMvY29uZmlnL0Nvbm5lY3RvckNvbmZpZy5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...esh/source/connector/s3/config/S3SourceConfig.java](https://app.codecov.io/gh/apache/eventmesh/pull/4132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbm5lY3RvcnMvc291cmNlLWNvbm5lY3Rvci1zMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NvdXJjZS9jb25uZWN0b3IvczMvY29uZmlnL1MzU291cmNlQ29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...urce/connector/s3/connector/S3SourceConnector.java](https://app.codecov.io/gh/apache/eventmesh/pull/4132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbm5lY3RvcnMvc291cmNlLWNvbm5lY3Rvci1zMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NvdXJjZS9jb25uZWN0b3IvczMvY29ubmVjdG9yL1MzU291cmNlQ29ubmVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4132/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1617678976

   @Alonexc @qqeasonchen @xwm1992 Hi~ PTAL again! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1606049631

   > > > please fix the build error.
   > > 
   > > 
   > > Could u rerun these ci?Some build error bugfix pr just have been merged to master branch just now
   > 
   > you can just merge the master branch code to your branch, this will re trigger the ci run.
   
   I have pushed the branch after rebasing, but it seems like that these ci need a maintainer to trigger~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1605995017

   > > please fix the build error.
   > 
   > Could u rerun these ci?Some build error bugfix pr just have been merged to master branch just now
   
   you can just merge the master branch code to your branch, this will re trigger the ci run. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1605840109

   > please fix the build error.
   
   Could u rerun these ci?Some build error bugfix pr just have been merged to master branch just now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "TheR1sing3un (via GitHub)" <gi...@apache.org>.
TheR1sing3un commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1595815028

   @xwm1992 PTAL~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4082][Task1] Support S3 file source connector (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #4132:
URL: https://github.com/apache/eventmesh/pull/4132#issuecomment-1598017155

   please fix the build error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org