You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ki...@apache.org on 2022/03/14 08:24:48 UTC

[incubator-seatunnel] branch dev updated: [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope (#1464)

This is an automated email from the ASF dual-hosted git repository.

kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new e6e1b7b  [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope (#1464)
e6e1b7b is described below

commit e6e1b7b576da37cb7e70a7186151ed29cd4115dc
Author: kalencaya <19...@qq.com>
AuthorDate: Mon Mar 14 16:24:41 2022 +0800

    [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope (#1464)
    
    * flink-connector-jdbc: plugin dependency scope and docs warning.
    
    * flink-connector-jdbc: add license info.
    
    * feature: add more guiding info for flink jdbc plugin docs.
    
    * feature: remove unused dependency.
    
    Co-authored-by: wangqi <wa...@xinc818.group>
---
 docs/en/flink/configuration/sink-plugins/Jdbc.md   | 4 +++-
 docs/en/flink/configuration/source-plugins/Jdbc.md | 4 +++-
 pom.xml                                            | 9 +--------
 seatunnel-dist/release-docs/LICENSE                | 1 +
 tools/dependencies/known-dependencies.txt          | 1 +
 5 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/docs/en/flink/configuration/sink-plugins/Jdbc.md b/docs/en/flink/configuration/sink-plugins/Jdbc.md
index d163915..e212cdc 100644
--- a/docs/en/flink/configuration/sink-plugins/Jdbc.md
+++ b/docs/en/flink/configuration/sink-plugins/Jdbc.md
@@ -22,7 +22,9 @@ Write data through jdbc
 
 ### driver [string]
 
-Driver name, such as `com.mysql.jdbc.Driver`
+Driver name, such as `com.mysql.cj.jdbc.Driver` for MySQL.
+
+Warn: for license compliance, you have to provide MySQL JDBC driver yourself, e.g. copy `mysql-connector-java-xxx.jar` to `$FLINK_HOME/lib` for Standalone.
 
 ### url [string]
 
diff --git a/docs/en/flink/configuration/source-plugins/Jdbc.md b/docs/en/flink/configuration/source-plugins/Jdbc.md
index 61c0818..9360867 100644
--- a/docs/en/flink/configuration/source-plugins/Jdbc.md
+++ b/docs/en/flink/configuration/source-plugins/Jdbc.md
@@ -21,7 +21,9 @@ Read data through jdbc
 
 ### driver [string]
 
-Driver name, such as `com.mysql.jdbc.Driver`
+Driver name, such as `com.mysql.cj.jdbc.Driver` for MySQL.
+
+Warn: for license compliance, you have to provide MySQL JDBC driver yourself, e.g. copy `mysql-connector-java-xxx.jar` to `$FLINK_HOME/lib` for Standalone.
 
 ### url [string]
 
diff --git a/pom.xml b/pom.xml
index c6099e5..9618423 100644
--- a/pom.xml
+++ b/pom.xml
@@ -219,13 +219,6 @@
 
             <dependency>
                 <groupId>org.apache.flink</groupId>
-                <artifactId>flink-connector-jdbc_${scala.binary.version}</artifactId>
-                <version>${flink.version}</version>
-                <scope>${flink.scope}</scope>
-            </dependency>
-
-            <dependency>
-                <groupId>org.apache.flink</groupId>
                 <artifactId>flink-table-common</artifactId>
                 <version>${flink.version}</version>
                 <scope>${flink.scope}</scope>
@@ -339,7 +332,7 @@
 
             <dependency>
                 <groupId>org.apache.flink</groupId>
-                <artifactId>flink-jdbc_${scala.binary.version}</artifactId>
+                <artifactId>flink-connector-jdbc_${scala.binary.version}</artifactId>
                 <version>${flink.version}</version>
             </dependency>
 
diff --git a/seatunnel-dist/release-docs/LICENSE b/seatunnel-dist/release-docs/LICENSE
index 23a9f9a..8b362ba 100644
--- a/seatunnel-dist/release-docs/LICENSE
+++ b/seatunnel-dist/release-docs/LICENSE
@@ -687,6 +687,7 @@ The text of each license is the standard Apache 2.0 license.
      (The Apache Software License, Version 2.0) Flink : Connectors : Elasticsearch base (org.apache.flink:flink-connector-elasticsearch-base_2.11:1.13.6 - https://flink.apache.org/flink-connectors/flink-connector-elasticsearch-base_2.11)
      (The Apache Software License, Version 2.0) Flink : Connectors : File Sink Common (org.apache.flink:flink-file-sink-common:1.13.6 - https://flink.apache.org/flink-connectors/flink-file-sink-common)
      (The Apache Software License, Version 2.0) Flink : Connectors : Files (org.apache.flink:flink-connector-files:1.13.6 - https://flink.apache.org/flink-connectors/flink-connector-files)
+     (The Apache Software License, Version 2.0) Flink : Connectors : JDBC (org.apache.flink:flink-connector-jdbc_2.11:1.13.6 - https://flink.apache.org/flink-connectors/flink-connector-jdbc_2.11)
      (The Apache Software License, Version 2.0) Flink : Connectors : Kafka (org.apache.flink:flink-connector-kafka_2.11:1.13.6 - https://flink.apache.org/flink-connectors/flink-connector-kafka_2.11)
      (The Apache Software License, Version 2.0) Flink : Core (org.apache.flink:flink-core:1.13.6 - https://flink.apache.org/flink-core)
      (The Apache Software License, Version 2.0) Flink : FileSystems : Hadoop FS (org.apache.flink:flink-hadoop-fs:1.13.6 - https://flink.apache.org/flink-filesystems/flink-hadoop-fs)
diff --git a/tools/dependencies/known-dependencies.txt b/tools/dependencies/known-dependencies.txt
index 75a7f53..9e0b589 100755
--- a/tools/dependencies/known-dependencies.txt
+++ b/tools/dependencies/known-dependencies.txt
@@ -160,6 +160,7 @@ flink-avro-1.13.6.jar
 flink-connector-base-1.13.6.jar
 flink-connector-elasticsearch-base_2.11-1.13.6.jar
 flink-connector-elasticsearch6_2.11-1.13.6.jar
+flink-connector-jdbc_2.11-1.13.6.jar
 flink-connector-kafka_2.11-1.13.6.jar
 flink-csv-1.13.6.jar
 flink-json-1.13.6.jar