You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by jlahoda <gi...@git.apache.org> on 2017/10/01 20:27:47 UTC

[GitHub] incubator-netbeans pull request #35: -external library Apache felix. Changed...

GitHub user jlahoda opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/35

    -external library Apache felix. Changed coordinates to Maven. File na…

    …me changed, adjusted. License Apache License v2.0. -notice.txt added based on NOTICE from Felix.
    
    -checked Rat report; no license header in binaries-list (added)
    
    -fixed version in -license.txt
    
    -skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jlahoda/incubator-netbeans libs.felix-review

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 4c5e4f31c8f8e4a296d4031236fc14ef5bd86aa4
Author: Jan Lahoda <jl...@netbeans.org>
Date:   2017-09-24T05:52:49Z

    -external library Apache felix. Changed coordinates to Maven. File name changed, adjusted. License Apache License v2.0. -notice.txt added based on NOTICE from Felix.
    
    -checked Rat report; no license header in binaries-list (added)
    
    -fixed version in -license.txt
    
    -skimmed through the module, did not notice additional problems

----


---

[GitHub] incubator-netbeans pull request #35: -external library Apache felix. Changed...

Posted by jlahoda <gi...@git.apache.org>.

Github user jlahoda closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/35


---

[GitHub] incubator-netbeans issue #35: -external library Apache felix. Changed coordi...

Posted by jlahoda <gi...@git.apache.org>.

Github user jlahoda commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/35
  
    Merged this pull request:
    https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=commit;h=3814587fcc8ae6712840b2d6c78126cb02b641e7


---

[GitHub] incubator-netbeans issue #35: -external library Apache felix. Changed coordi...

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/35
  
    Looks good - comment from #33 about the commit message applies here as well. 


---