[GitHub] rdblue commented on issue #82: Make expression binding support a case sensitivity flag

[GitBox <gi...@apache.org>]

rdblue commented on issue #82: Make expression binding support a case sensitivity flag
URL: https://github.com/apache/incubator-iceberg/pull/82#issuecomment-456511762
 
 
   Thanks for the update, @xabriel!
   
   Adding a `caseSensitive` flag requires quite a few updates elsewhere, and method calls are less readable because of the boolean argument (we'll forget what `true` signals). What do you think about adding versions of these methods that don't have the flag and default to case sensitive?
   
   The drawback is that it will be easy to not pay attention later and use case sensitive matching when it shouldn't be. But I think that would be okay. At least for tests, a package-private version that defaults to case sensitive would cut down on a lot of code changes.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org