[I] Sankey Diagram's value column is summed but declares no attributeTypeRules, so a string column silently renders a broken diagram [texera]

["kz930 (via GitHub)" <gi...@apache.org>]

kz930 opened a new issue, #7319:
URL: https://github.com/apache/texera/issues/7319

   ### What happened?
   
   `attributeTypeRules` is how an operator states which column types a picker accepts, and upstream already uses it wherever a chart consumes a column as a quantity — Range Slider constrains its `Y-axis` to integer, long and double precisely because that column is aggregated.
   
   Sankey Diagram consumes `Value Attribute` the same way: it groups by source and target and sums that column into the link width. It declares no rule at all, so the form offers every column and accepts a string one. When it does, the sum concatenates instead of adding, and the concatenated text reaches plotly as the link value. Plotly accepts non-numeric link values without complaint, so the diagram renders and looks finished while its links carry no meaningful width — the failure is invisible to the user.
   
   Expected: the picker offers only integer, long and double, the way Range Slider's `Y-axis` does.
   
   ### How to reproduce?
   
   Drop a Sankey Diagram after any source that has a string column and select that column as `Value Attribute`. With a three-row frame whose `src`/`dst` are `n1→n2`, `n1→n2`, `n2→n3` and whose string value column holds `a`, `b`, `c`, the group-and-sum yields `ab` and `c`, plotly receives `link.value = ('ab', 'c')`, and the chart renders with no error and no warning.
   
   ### Version/Branch
   
   1.3.0-incubating-SNAPSHOT (main)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Sankey Diagram's value column is summed but declares no attributeTypeRules, so a string column silently renders a broken diagram [texera]

["aglinxinyuan (via GitHub)" <gi...@apache.org>]

aglinxinyuan closed issue #7319: Sankey Diagram's value column is summed but declares no attributeTypeRules, so a string column silently renders a broken diagram
URL: https://github.com/apache/texera/issues/7319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Sankey Diagram's value column is summed but declares no attributeTypeRules, so a string column silently renders a broken diagram [texera]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on issue #7319:
URL: https://github.com/apache/texera/issues/7319#issuecomment-5187053469

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @kz930!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Sankey Diagram's value column is summed but declares no attributeTypeRules, so a string column silently renders a broken diagram [texera]

["kz930 (via GitHub)" <gi...@apache.org>]

kz930 commented on issue #7319:
URL: https://github.com/apache/texera/issues/7319#issuecomment-5187825524

   /take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org