You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by zmyer <gi...@git.apache.org> on 2016/12/23 17:44:59 UTC
[GitHub] geode pull request #325: merge new version
GitHub user zmyer opened a pull request:
https://github.com/apache/geode/pull/325
merge new version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zmyer/incubator-geode develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #325
----
commit a3e78ce36157f61ee2b5d1c0d7b6fe4f20016d6a
Author: zmyer <zh...@126.com>
Date: 2016-09-11T14:34:51Z
this is a test
commit cbb0744f2c9e204fe5978139dfb69acc167bb1da
Author: zmyer <zh...@126.com>
Date: 2016-09-12T15:48:23Z
add author
commit a51905877ad8e049d5f69ef1846998a56ad7a341
Author: zmyer <zh...@126.com>
Date: 2016-10-01T17:48:57Z
refactor AbstractOp class
commit ecfcf0d5eca39224d683caf5ac54a883d0f0e4ff
Author: zmyer <zh...@126.com>
Date: 2016-10-02T13:24:22Z
refactor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #325: merge new version
Posted by metatype <gi...@git.apache.org>.
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/325
Thanks for the contribution. However, I'm currently -1 until you clarify the purpose of the change and follow some of the recommendations included in our project contribution guidelines such as:
- You need to file a JIRA for any change to the code base. This helps drive discussion / consensus and makes it easy to do release notes.
- Separate code reformatting changes from actual logic changes. This makes it easier to review.
- Don't include \@author tags
- Use `git rebase -i` to squash commits like 'this is a test'. We only want to see useful commits in our git history
- We use spotless to manage the source code formatting. If you want to change the format, please start a discussion on the dev@geode list.
See the wiki pages for more details:
https://cwiki.apache.org/confluence/display/GEODE/How+to+Contribute
Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #325: merge new version
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/325
Is this PR still open or relevant? If not, could we please close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #325: merge new version
Posted by zmyer <gi...@git.apache.org>.
Github user zmyer closed the pull request at:
https://github.com/apache/geode/pull/325
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #325: merge new version
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/325
@zmyer could you please confirm that this PR is still relevant. If not I will close it CoB tomorrow ( 25 Aug)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---