[GitHub] [hadoop] tasanuma commented on a diff in pull request #4901: HDFS-16776 Erasure Coding: The length of targets should be checked when DN gets a reconstruction task

[GitBox <gi...@apache.org>]

tasanuma commented on code in PR #4901:
URL: https://github.com/apache/hadoop/pull/4901#discussion_r976232952


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedReconstructor.java:
##########
@@ -288,6 +292,10 @@ RawErasureDecoder getDecoder() {
     return decoder;
   }
 
+  int getIndicesNum(){
+    return liveIndiceNum;
+  }
+

Review Comment:
   @Kidd53685368 Thanks for your PR.
   How about using `BitSet#cardinality` instead of calculating `liveIndiceNum`?
   ```suggestion
     int getNumLiveBlocks(){
       return liveBitSet.cardinality();
     }
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org