You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tamás Cservenák (Jira)" <ji...@apache.org> on 2021/01/23 19:03:00 UTC
[jira] [Updated] (MRESOLVER-161) Resolve circular dependency
resolver -> maven -> resolver
[ https://issues.apache.org/jira/browse/MRESOLVER-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tamás Cservenák updated MRESOLVER-161:
--------------------------------------
Description:
Apache Maven Resolver has a module {{maven-resolver-demo-snippets}} that in turn depends on Maven {{maven-resolver-provider}} that naturally depends on Maven Resolver.
Since MRESOLVER-154 is implemented, the "demo snippets" does not work: maven-resolver has class moved (introduced binary incompatibility), while maven-resolver-provider expects it in it's old place. All in all, this "cycle" is actually bad, as same issue will hit us with removal of service locator as well MRESOLVER-157.
Proposals: move the "resolver demos" out of resolver project completely, as it needs maven to make resolver usable with maven metadata/pom, but, due this cycle it puts everything into concrete, and harder to change thing. Or, any other idea?
Rationale:
- "resolver demos" are just that: a showcase how to use resolver (with maven), but alas, maven-resolver is incomplete in this respect (as it lacks maven models, mode builder, etc), so the cycle is here due those bits. So, imo a separate project/repo is most probably justified for it, as they are NOT executed/run during maven-resolver build anyway, the fact they are broken (see MRESOLVER-162) was discovered by manually running them).
was:
Apache Maven Resolver has a module {{maven-resolver-demo-snippets}} that in turn depends on Maven {{maven-resolver-provider}} that naturally depends on Maven Resolver.
Since MRESOLVER-154 is implemented, the "demo snippets" does not work: maven-resolver has class moved (introduced binary incompatibility), while maven-resolver-provider expects it in it's old place. All in all, this "cycle" is actually bad, as same issue will hit us with removal of service locator as well MRESOLVER-157.
Proposals: move the "resolver demos" out of resolver project completely, as it needs maven to make resolver usable with maven metadata/pom, but, due this cycle it puts everything into concrete, and harder to change thing. Or, any other idea?
Rationale:
- "resolver demos" are just that: a showcase how to use resolver (with maven), but alas, maven-resolver is incomplete in this respect (as it lacks maven models, mode builder, etc), so the cycle is here due those bits. So, imo a separate project/repo is most probably justified for it, as they are NOT executed/run during maven-resolver build anyway (the fact they are broken, see MRESOLVER-162) was discovered by manually running them).
> Resolve circular dependency resolver -> maven -> resolver
> ---------------------------------------------------------
>
> Key: MRESOLVER-161
> URL: https://issues.apache.org/jira/browse/MRESOLVER-161
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamás Cservenák
> Priority: Major
>
> Apache Maven Resolver has a module {{maven-resolver-demo-snippets}} that in turn depends on Maven {{maven-resolver-provider}} that naturally depends on Maven Resolver.
> Since MRESOLVER-154 is implemented, the "demo snippets" does not work: maven-resolver has class moved (introduced binary incompatibility), while maven-resolver-provider expects it in it's old place. All in all, this "cycle" is actually bad, as same issue will hit us with removal of service locator as well MRESOLVER-157.
> Proposals: move the "resolver demos" out of resolver project completely, as it needs maven to make resolver usable with maven metadata/pom, but, due this cycle it puts everything into concrete, and harder to change thing. Or, any other idea?
> Rationale:
> - "resolver demos" are just that: a showcase how to use resolver (with maven), but alas, maven-resolver is incomplete in this respect (as it lacks maven models, mode builder, etc), so the cycle is here due those bits. So, imo a separate project/repo is most probably justified for it, as they are NOT executed/run during maven-resolver build anyway, the fact they are broken (see MRESOLVER-162) was discovered by manually running them).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)