[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6179: GEODE-6143: Remove PowerMock from offheap tests

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #6179:
URL: https://github.com/apache/geode/pull/6179#discussion_r601692247



##########
File path: geode-core/src/main/java/org/apache/geode/internal/offheap/ReferenceCountHelper.java
##########
@@ -81,72 +85,72 @@ public static Object createReferenceCountOwner() {
    * of this method must also call unskipRefCountTracking after the allocation or free is done.
    */
   public static void skipRefCountTracking() {
-    getInstance().skipRefCountTracking();
+    delegate().skipRefCountTracking();
   }
 
   /**
    * Returns true if currently tracking reference counts.
    */
-  public static boolean isRefCountTracking() {
-    return getInstance().isRefCountTracking();
+  static boolean isRefCountTracking() {

Review comment:
       be careful with this. You could check with Eric but I think some of these methods are used when trying to debug offheap leaks (i.e. orphans)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org