You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/28 10:05:15 UTC
[GitHub] [dolphinscheduler-website] Tianqi-Dotes opened a new pull request #751: [FIX] [WEBSITE-9224] fix wechat CN and EN documents
Tianqi-Dotes opened a new pull request #751:
URL: https://github.com/apache/dolphinscheduler-website/pull/751
fix wechat CN and EN documents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on pull request #751: [FIX] [WEBSITE-9224] fix wechat CN and EN documents
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on pull request #751:
URL: https://github.com/apache/dolphinscheduler-website/pull/751#issuecomment-1082805342
> LGTM, but the ds alert screenshot is missing, I think it's better to wait for the UI part to be ready and add the ds screenshot. What do you think?
Will add ds screenshot after done change the json format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on pull request #751: [FIX] [WEBSITE-9224] fix wechat CN and EN documents
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on pull request #751:
URL: https://github.com/apache/dolphinscheduler-website/pull/751#issuecomment-1080809379
@caishunfeng PTAL at the CN version, have added image illustrations. Much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on pull request #751: [FIX] [WEBSITE-9224] fix wechat CN and EN documents
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on pull request #751:
URL: https://github.com/apache/dolphinscheduler-website/pull/751#issuecomment-1080809804
@zhongjiajie PTAL at the EN version. Much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #751: [FIX] [WEBSITE-9224] fix wechat CN and EN documents
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #751:
URL: https://github.com/apache/dolphinscheduler-website/pull/751#issuecomment-1081346749
> @zhongjiajie PTAL at the EN version. Much appreciated.
tips you're committer now, and you could require team members(committer or PMC) to review specific PR or issues, which you could see in. Personally, I will see our team required firstly when I browse github notification
<img width="476" alt="image" src="https://user-images.githubusercontent.com/15820530/160523563-1ddf6f0a-6870-43f0-a1ef-3eb5efea8b53.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on pull request #751: [FIX] [WEBSITE-9224] fix wechat CN and EN documents
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on pull request #751:
URL: https://github.com/apache/dolphinscheduler-website/pull/751#issuecomment-1082809855
> Looking good, but could you please change the picture to the English version? I find `enterprise-webchat-app-msg.png` and `enterprise-wechat-create-group.png` content Chinses content
Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #751: [FIX] [WEBSITE-9224] fix wechat CN and EN documents
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #751:
URL: https://github.com/apache/dolphinscheduler-website/pull/751#issuecomment-1085988139
I add the label `missing-ui` based on https://github.com/apache/dolphinscheduler-website/pull/751#pullrequestreview-924549605, mean this PR could not be merge unless we add UI part to it. Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org