You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/20 02:46:59 UTC
[GitHub] [apisix] spacewander opened a new pull request #6384: change(admin): empty nodes should be encoded as array
spacewander opened a new pull request #6384:
URL: https://github.com/apache/apisix/pull/6384
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #6384: change(admin): empty nodes should be encoded as array
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #6384:
URL: https://github.com/apache/apisix/pull/6384#issuecomment-1046244781
> For Go program, after this fix, an empty `nodes` will be decoded to an empty slice instead of `nil`.
>
> @tao12345666333 @nic-chen @bzp2010 Could you help me confirm if this change affects other projects? Thanks!
Thanks. Dashboard-related projects have no effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tao12345666333 commented on pull request #6384: change(admin): empty nodes should be encoded as array
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #6384:
URL: https://github.com/apache/apisix/pull/6384#issuecomment-1046228076
I will confirm if the ingress project will be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6384: change(admin): empty nodes should be encoded as array
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6384:
URL: https://github.com/apache/apisix/pull/6384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #6384: change(admin): empty nodes should be encoded as array
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #6384:
URL: https://github.com/apache/apisix/pull/6384#issuecomment-1046227772
For Go program, after this fix, an empty `nodes` will be decoded to an empty slice instead of `nil`.
@tao12345666333 @nic-chen @bzp2010
Could you help me confirm if this change affects other projects? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org