You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Stefano Bagnara (JIRA)" <se...@james.apache.org> on 2006/09/08 19:49:23 UTC
[jira] Commented: (JAMES-609) MailImpl.setMessage and possible NPE:
regression from 2.2.0 and 2.3.0rc1
[ http://issues.apache.org/jira/browse/JAMES-609?page=comments#action_12433460 ]
Stefano Bagnara commented on JAMES-609:
---------------------------------------
I believe the NPE could be thrown when saving the message after having called SMIMECheckSignature when "stripSignature && strippedMessage != null" because it calls setMessage with the same message.
> MailImpl.setMessage and possible NPE: regression from 2.2.0 and 2.3.0rc1
> ------------------------------------------------------------------------
>
> Key: JAMES-609
> URL: http://issues.apache.org/jira/browse/JAMES-609
> Project: James
> Issue Type: Bug
> Components: James Core
> Affects Versions: 2.3.0rc2
> Reporter: Stefano Bagnara
> Fix For: 2.3.0rc3
>
>
> The change introduced in rc2 to fix the file leaks has produced an NPE in a custom mailet.
> I suggest to revert the setMessage changes removing the dispose() call for the old message and to put the dispose code in the bundled calling mailets.
> This is not a good fix in the long term, but for 2.3.0 I would prefer to keep compatibility with 2.2.0 and to have a leak instead of NPE (difficult to understand by most users).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org