You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/23 01:21:23 UTC
[GitHub] [spark] Yikun opened a new pull request, #38353: [SPARK-40881][INFRA] Upgrade actions/cache to v3 and actions/upload-artifact to v3
Yikun opened a new pull request, #38353:
URL: https://github.com/apache/spark/pull/38353
### What changes were proposed in this pull request?
Upgrade actions/cache to v3 and actions/upload-artifact to v3
### Why are the changes needed?
- Since actions/cache@v3: support from node 12 -> node 16.
- Since actions/upload-artifact@v3: cleanup `set-output` warning
### Does this PR introduce _any_ user-facing change?
No, dev only
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38353: [SPARK-40881][INFRA] Upgrade actions/cache to v3 and actions/upload-artifact to v3
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38353:
URL: https://github.com/apache/spark/pull/38353#issuecomment-1288493288
CI passed, will merge soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun closed pull request #38353: [SPARK-40881][INFRA] Upgrade actions/cache to v3 and actions/upload-artifact to v3
Posted by GitBox <gi...@apache.org>.
Yikun closed pull request #38353: [SPARK-40881][INFRA] Upgrade actions/cache to v3 and actions/upload-artifact to v3
URL: https://github.com/apache/spark/pull/38353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38353: [SPARK-40881][INFRA] Upgrade actions/cache to v3 and actions/upload-artifact to v3
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38353:
URL: https://github.com/apache/spark/pull/38353#issuecomment-1288297240
@srowen Thanks, might be rebase issue. Let me do a rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #38353: [SPARK-40881][INFRA] Upgrade actions/cache to v3 and actions/upload-artifact to v3
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38353:
URL: https://github.com/apache/spark/pull/38353#issuecomment-1288151179
Looks OK if tests pass; looks like an unrelated error:
```
RUN: /__w/spark/spark/connector/connect/dev/generate_protos.sh /tmp/tmpvqg44rqj
Different files: ['base_pb2.pyi', 'commands_pb2.pyi', 'expressions_pb2.pyi', 'relations_pb2.pyi', 'types_pb2.pyi']
Generated files for pyspark-connect are out of sync! If you have touched files under connector/connect/src/main/protobuf, please run ./connector/connect/dev/generate_protos.sh. If you haven't touched any file above, please rebase your PR against main branch.
Error: Process completed with exit code 255.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38353: [SPARK-40881][INFRA] Upgrade actions/cache to v3 and actions/upload-artifact to v3
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38353:
URL: https://github.com/apache/spark/pull/38353#issuecomment-1288494398
@srowen @LuciferYang Thanks, merged to master (3.4.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org