[GitHub] [doris] liaoxin01 commented on a diff in pull request #20720: [Fix](MOW) Fix load data publish timeout when enable unique key MOW

["liaoxin01 (via GitHub)" <gi...@apache.org>]

liaoxin01 commented on code in PR #20720:
URL: https://github.com/apache/doris/pull/20720#discussion_r1228238880


##########
be/src/olap/tablet.cpp:
##########
@@ -3126,10 +3126,34 @@ Status Tablet::update_delete_bitmap_without_lock(const RowsetSharedPtr& rowset)
     return Status::OK();
 }
 
-Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, const TabletTxnInfo* load_info,
-                                    RowsetWriter* rowset_writer) {
-    DeleteBitmapPtr delete_bitmap = load_info->delete_bitmap;
-    const RowsetIdUnorderedSet& pre_rowset_ids = load_info->rowset_ids;
+Status Tablet::commit_phase_update_delete_bitmap(
+        const RowsetSharedPtr& rowset, const RowsetIdUnorderedSet& pre_rowset_ids,
+        DeleteBitmapPtr delete_bitmap, const int64_t& cur_version,
+        const std::vector<segment_v2::SegmentSharedPtr>& segments, RowsetWriter* rowset_writer) {
+    RowsetIdUnorderedSet cur_rowset_ids;
+    RowsetIdUnorderedSet rowset_ids_to_add;
+    RowsetIdUnorderedSet rowset_ids_to_del;
+
+    std::lock_guard<std::mutex> rwlock(_rowset_update_lock);

Review Comment:
   don't need  to lock _rowset_update_lock here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org