You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/28 15:09:48 UTC

[GitHub] [dubbo-go] Lvnszn opened a new pull request #1547: WIP: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Lvnszn opened a new pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**:
   upgrade dubbo-getty from 1.4.5 to 1.4.6, 
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #1547: [WIP] Opt: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547#issuecomment-958656104


   Pls do not merge this pr until a new dubbo-getty release version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] Lvnszn commented on pull request #1547: Opt: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Posted by GitBox <gi...@apache.org>.
Lvnszn commented on pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547#issuecomment-955144088


   > ![image](https://user-images.githubusercontent.com/7959374/139378918-e982f871-b81c-491d-a65d-f8578e789d67.png)
   > 
   > Pls refer from the above chat context, improve the following codes.
   > 
   > https://github.com/apache/dubbo-go/blob/c378031a059b078171edcbc1f3a3b19214486318/protocol/dubbo/impl/codec.go#L269
   > 
   > Send out the huge network package slice by slice in order. The slice length maybe less than or equal to 16k as your experience.
   
   will fix it in dubbo-getty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #1547: [WIP] Opt: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547#issuecomment-958656104


   Pls do not merge this pr until a new dubbo-getty release version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1547: Opt: upgrade dubbo-getty from 1.4.5 to 1.4.7-rc2

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1547: WIP: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547#issuecomment-954371177


   @Lvnszn You can remove WIP if it is able to be merged, I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #1547: WIP: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547#issuecomment-954435986


   ![image](https://user-images.githubusercontent.com/7959374/139378918-e982f871-b81c-491d-a65d-f8578e789d67.png)
   
   Pls refer from the above chat context, improve the following codes.
   
   https://github.com/apache/dubbo-go/blob/c378031a059b078171edcbc1f3a3b19214486318/protocol/dubbo/impl/codec.go#L269
   
   Send out the huge network package slice by slice in order. The slice length maybe less than or equal to 16k as your experience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #1547: [WIP] Opt: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547#issuecomment-958656104






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1547: [WIP] Opt: upgrade dubbo-getty from 1.4.5 to 1.4.6,

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1547:
URL: https://github.com/apache/dubbo-go/pull/1547#issuecomment-985992955


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1547?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1547](https://codecov.io/gh/apache/dubbo-go/pull/1547?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e2c93d) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/ec43e227cf1d0112eb13ca7a5702b1e184f818b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec43e22) will **increase** coverage by `0.72%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 4e2c93d differs from pull request most recent head e616e6b. Consider uploading reports for the commit e616e6b to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1547/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1547      +/-   ##
   ==========================================
   + Coverage   41.12%   41.84%   +0.72%     
   ==========================================
     Files         253      258       +5     
     Lines       14501    15121     +620     
   ==========================================
   + Hits         5964     6328     +364     
   - Misses       7847     8057     +210     
   - Partials      690      736      +46     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1547?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `49.18% <0.00%> (-13.84%)` | :arrow_down: |
   | [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.46% <0.00%> (-12.90%)` | :arrow_down: |
   | [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `21.62% <0.00%> (-8.11%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <0.00%> (-3.29%)` | :arrow_down: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `34.37% <0.00%> (-3.21%)` | :arrow_down: |
   | [filter/gshutdown/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2dzaHV0ZG93bi9maWx0ZXIuZ28=) | `60.00% <0.00%> (-2.17%)` | :arrow_down: |
   | [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `73.62% <0.00%> (-1.63%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `9.39% <0.00%> (-1.40%)` | :arrow_down: |
   | [filter/auth/default\_authenticator.go](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvZGVmYXVsdF9hdXRoZW50aWNhdG9yLmdv) | `80.00% <0.00%> (-1.25%)` | :arrow_down: |
   | ... and [62 more](https://codecov.io/gh/apache/dubbo-go/pull/1547/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1547?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1547?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ec43e22...e616e6b](https://codecov.io/gh/apache/dubbo-go/pull/1547?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org