[jira] [Commented] (OFBIZ-5578) Quick Ship Entire Order Never Shipping

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057287#comment-14057287 ] 

Jacques Le Roux commented on OFBIZ-5578:
----------------------------------------

Hi Jacopo, should we not create a Jira for this error, maybe one exists already?

> Quick Ship Entire Order Never Shipping
> --------------------------------------
>
>                 Key: OFBIZ-5578
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5578
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Trunk, Release Branch 12.04
>            Reporter: Darrell Donati
>            Assignee: Jacopo Cappellato
>             Fix For: Release Branch 11.04, Trunk, Release Branch 12.04, Release Branch 13.07
>
>         Attachments: OFBIZ-5578-Quick Ship Entire Order Never Shipping.log, ShipmentServices.xml.patch
>
>
> The quickShipEntireOrder in ShipmentServices.xml takes in an optional field called "setPackedOnly". This check for setPackedOnly was added to 'createShipmentForFacilityAndShipGroup' in r1139346. QuickShipEntireOrder also calls the 'createShipmentForFacilityAndShipGroup' simple method, but setPackedOnly is never set in the context before making the call, meaning that setPackedOnly is always empty when it's checked in the method. 
> Additionally, the check on setPackedOnly is written such that if setPackedOnly is NOT empty, the status is taken to SHIPPED. Instead, it makes sense for it to be taken to SHIPPED status when setPackedOnly IS empty (see 'setShipmentStatusPackedAndShipped' Line 1719).
> See my original thread on the ML here: http://ofbiz.135035.n4.nabble.com/Quick-Ship-Order-Status-Service-td4648696.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)