You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Mark Bretl <mb...@pivotal.io> on 2015/11/03 21:07:55 UTC
Review Request 39876: GEODE-227: Extract library versions into a build
property file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39876/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
Bugs: GEODE-227
https://issues.apache.org/jira/browse/GEODE-227
Repository: geode
Description
-------
Dependency versions are currently scattered throughout all the Gradle files, making it hard to manage when updating or simply making sure the same version is used for all projects. These changes extract all dependency version information into a single file, dependency-versions.properties, so only one file has to be edited any time a dependency version has changed.
Diffs
-----
build.gradle 7e477f39b6354b25853648d51330a8d5133500b7
gemfire-assembly/build.gradle b351729261473b40a3bc74067970a4a1c6d78c09
gemfire-core/build.gradle 1c1747447b082130a1c5860f52acac28e1a5b28d
gemfire-jgroups/build.gradle 30587bb05ae2fc1798e2bf9b727d55719b1f1222
gemfire-rebalancer/build.gradle d87dd58ac5a532aa1e91652886ed30dd897b5484
gemfire-web-api/build.gradle 81eec6dd4b805a8e82ee24340f2bc1a764d1e242
gemfire-web/build.gradle b9629d30a66d70e9283987ab2db8d4bb2b2f08a1
gradle/dependency-versions.properties PRE-CREATION
Diff: https://reviews.apache.org/r/39876/diff/
Testing
-------
Executed 'clean precheckin'
Thanks,
Mark Bretl
Re: Review Request 39876: GEODE-227: Extract library versions into a
build property file
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39876/#review105338
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Nov. 6, 2015, 12:22 a.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39876/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 12:22 a.m.)
>
>
> Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
>
>
> Bugs: GEODE-227
> https://issues.apache.org/jira/browse/GEODE-227
>
>
> Repository: geode
>
>
> Description
> -------
>
> Dependency versions are currently scattered throughout all the Gradle files, making it hard to manage when updating or simply making sure the same version is used for all projects. These changes extract all dependency version information into a single file, dependency-versions.properties, so only one file has to be edited any time a dependency version has changed.
>
>
> Diffs
> -----
>
> build.gradle 9aa967bd182161cfabfefdfa4ee1ea71491b9787
> gemfire-assembly/build.gradle ed0bb86773af3d2f8d1d160c6f068b4cd0a990d7
> gemfire-core/build.gradle 47a84f34c73faac55e1308245d33c2e99b0e68c3
> gemfire-jgroups/build.gradle 30587bb05ae2fc1798e2bf9b727d55719b1f1222
> gemfire-rebalancer/build.gradle 1226a7e0110eadfc61c74be2c6e0a7eb1b3867bd
> gemfire-web-api/build.gradle 81eec6dd4b805a8e82ee24340f2bc1a764d1e242
> gemfire-web/build.gradle 564b07d1426fdb0ced3c233d7de8acbed1861a81
> gradle/dependency-versions.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39876/diff/
>
>
> Testing
> -------
>
> Executed 'clean precheckin'
>
>
> Thanks,
>
> Mark Bretl
>
>
Re: Review Request 39876: GEODE-227: Extract library versions into a
build property file
Posted by Mark Bretl <mb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39876/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 12:22 a.m.)
Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
Changes
-------
Added property loader, which was missing from earlier diff
Bugs: GEODE-227
https://issues.apache.org/jira/browse/GEODE-227
Repository: geode
Description
-------
Dependency versions are currently scattered throughout all the Gradle files, making it hard to manage when updating or simply making sure the same version is used for all projects. These changes extract all dependency version information into a single file, dependency-versions.properties, so only one file has to be edited any time a dependency version has changed.
Diffs (updated)
-----
build.gradle 9aa967bd182161cfabfefdfa4ee1ea71491b9787
gemfire-assembly/build.gradle ed0bb86773af3d2f8d1d160c6f068b4cd0a990d7
gemfire-core/build.gradle 47a84f34c73faac55e1308245d33c2e99b0e68c3
gemfire-jgroups/build.gradle 30587bb05ae2fc1798e2bf9b727d55719b1f1222
gemfire-rebalancer/build.gradle 1226a7e0110eadfc61c74be2c6e0a7eb1b3867bd
gemfire-web-api/build.gradle 81eec6dd4b805a8e82ee24340f2bc1a764d1e242
gemfire-web/build.gradle 564b07d1426fdb0ced3c233d7de8acbed1861a81
gradle/dependency-versions.properties PRE-CREATION
Diff: https://reviews.apache.org/r/39876/diff/
Testing
-------
Executed 'clean precheckin'
Thanks,
Mark Bretl
Re: Review Request 39876: GEODE-227: Extract library versions into a
build property file
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39876/#review105314
-----------------------------------------------------------
I don't see how the build is actually loading that properties file. Otherwise, looks good.
- Dan Smith
On Nov. 3, 2015, 8:07 p.m., Mark Bretl wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39876/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 8:07 p.m.)
>
>
> Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith.
>
>
> Bugs: GEODE-227
> https://issues.apache.org/jira/browse/GEODE-227
>
>
> Repository: geode
>
>
> Description
> -------
>
> Dependency versions are currently scattered throughout all the Gradle files, making it hard to manage when updating or simply making sure the same version is used for all projects. These changes extract all dependency version information into a single file, dependency-versions.properties, so only one file has to be edited any time a dependency version has changed.
>
>
> Diffs
> -----
>
> build.gradle 7e477f39b6354b25853648d51330a8d5133500b7
> gemfire-assembly/build.gradle b351729261473b40a3bc74067970a4a1c6d78c09
> gemfire-core/build.gradle 1c1747447b082130a1c5860f52acac28e1a5b28d
> gemfire-jgroups/build.gradle 30587bb05ae2fc1798e2bf9b727d55719b1f1222
> gemfire-rebalancer/build.gradle d87dd58ac5a532aa1e91652886ed30dd897b5484
> gemfire-web-api/build.gradle 81eec6dd4b805a8e82ee24340f2bc1a764d1e242
> gemfire-web/build.gradle b9629d30a66d70e9283987ab2db8d4bb2b2f08a1
> gradle/dependency-versions.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39876/diff/
>
>
> Testing
> -------
>
> Executed 'clean precheckin'
>
>
> Thanks,
>
> Mark Bretl
>
>