You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by da...@apache.org on 2023/11/13 09:15:42 UTC
(kafka) branch trunk updated: MINOR: Fix ClusterConnectionStatesTest.testSingleIP (#14741)
This is an automated email from the ASF dual-hosted git repository.
dajac pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 49d3122d425 MINOR: Fix ClusterConnectionStatesTest.testSingleIP (#14741)
49d3122d425 is described below
commit 49d3122d425171b6a59a2b6f02d3fe63d3ac2397
Author: David Jacot <dj...@confluent.io>
AuthorDate: Mon Nov 13 10:15:35 2023 +0100
MINOR: Fix ClusterConnectionStatesTest.testSingleIP (#14741)
This test fails because `localhost` resolved to more than one IP on the Ci. This patch updates the ClusterConnectionStatesTest.testSingleIP test to use a static resolver.
Reviewers: Luke Chen <sh...@gmail.com>
---
.../org/apache/kafka/clients/ClusterConnectionStatesTest.java | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java b/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
index b16de1a3164..c672540cf9e 100644
--- a/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
+++ b/clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
@@ -32,6 +32,8 @@ import java.net.UnknownHostException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
+import java.util.stream.Stream;
+
import org.apache.kafka.common.errors.AuthenticationException;
import org.apache.kafka.common.utils.LogContext;
import org.apache.kafka.common.utils.MockTime;
@@ -264,7 +266,14 @@ public class ClusterConnectionStatesTest {
@Test
public void testSingleIP() throws UnknownHostException {
- assertEquals(1, ClientUtils.resolve("localhost", singleIPHostResolver).size());
+ InetAddress[] localhostIps = Stream.of(InetAddress.getByName("127.0.0.1")).toArray(InetAddress[]::new);
+ HostResolver hostResolver = host -> {
+ assertEquals("localhost", host);
+ return localhostIps;
+ };
+
+ connectionStates = new ClusterConnectionStates(reconnectBackoffMs, reconnectBackoffMax,
+ connectionSetupTimeoutMs, connectionSetupTimeoutMaxMs, new LogContext(), hostResolver);
connectionStates.connecting(nodeId1, time.milliseconds(), "localhost");
InetAddress currAddress = connectionStates.currentAddress(nodeId1);