You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ignitetcbot (via GitHub)" <gi...@apache.org> on 2026/05/15 18:49:32 UTC

[PR] Ignite 28684 fix draft [ignite]

ignitetcbot opened a new pull request, #13143:
URL: https://github.com/apache/ignite/pull/13143

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28684: MDC test fix with first nodes with predictable assingnment [ignite]

Posted by "dspavlov (via GitHub)" <gi...@apache.org>.
dspavlov merged PR #13143:
URL: https://github.com/apache/ignite/pull/13143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Ignite 28684 fix draft [ignite]

Posted by "ignitetcbot (via GitHub)" <gi...@apache.org>.
ignitetcbot commented on PR #13143:
URL: https://github.com/apache/ignite/pull/13143#issuecomment-4483626586

   <!-- tcbot-analysis-comment chainBuildId=9072492 rerunBuildIds=9077604,9077606,9077608,9077610,9077612,9077614,9077616,9077618,9077620,9077622,9077624,9077626,9077628,9077630,9077632,9077634,9077636,9077638,9077640,9077642,9077644 -->
   ### TCBot Test Analysis
   
   * TeamCity: [--> Run :: All Results](https://ci2.ignite.apache.org/viewLog.html?buildId=9072492&buildTypeId=IgniteTests24Java8_RunAll)
   * Branch: `pull/13143/head`
   * Base: `master`
   * Tested commit: [69f16c5](https://github.com/apache/ignite/pull/13143/commits/69f16c5040fd78bc444a84eeeeb8f2040807e22c)
   
   #### Possible Blockers (0)
   
   No blockers found.
   
   #### New Tests (0)
   
   No new tests found.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Ignite 28684 fix draft [ignite]

Posted by "vldpyatkov (via GitHub)" <gi...@apache.org>.
vldpyatkov commented on code in PR #13143:
URL: https://github.com/apache/ignite/pull/13143#discussion_r3257673811


##########
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/MultiDataCenterRingTest.java:
##########


Review Comment:
   The fix looks correct, but let's add parameters that designate which nodes would be guaranteed in the different DCs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Ignite 28684 fix draft [ignite]

Posted by "ignitetcbot (via GitHub)" <gi...@apache.org>.
ignitetcbot commented on PR #13143:
URL: https://github.com/apache/ignite/pull/13143#issuecomment-4464969164

   <!-- tcbot-analysis-comment chainBuildId=9072492 rerunBuildIds=none -->
   ### TCBot Test Analysis
   
   * TeamCity: [--> Run :: All Results](https://ci2.ignite.apache.org/viewLog.html?buildId=9072492&buildTypeId=IgniteTests24Java8_RunAll)
   * Branch: `pull/13143/head`
   * Base: `master`
   * Tested commit: [69f16c5](https://github.com/apache/ignite/pull/13143/commits/69f16c5040fd78bc444a84eeeeb8f2040807e22c)
   
   #### Possible Blockers (7)
   
   * [Queries 3](https://ci2.ignite.apache.org/viewLog.html?buildId=9072441): 1 tests
     * `IgniteBinaryCacheQueryTestSuite3`: `SqlPartitionEvictionTest.testSqlConsistencyOnEviction[backups_count=2]` - Test has low fail rate in base branch 0,0% and is not flaky
   * [Platform C++ CMake (Win x64 | Release)](https://ci2.ignite.apache.org/viewLog.html?buildId=9072434): 0 tests JVM CRASH 
     * Jvm Crash is a blocker. Base branch critical fail rate is 6,7%   
   * [Snapshots 2](https://ci2.ignite.apache.org/viewLog.html?buildId=9072466): 1 tests
     * `IgniteSnapshotTestSuite2`: `IgniteSnapshotMXBeanTest.testCreateSnapshot[encryption=false, onlyPrimay=true]` - Test has low fail rate in base branch 0,0% and is not flaky
   * [Cache 12](https://ci2.ignite.apache.org/viewLog.html?buildId=9072373): 0 tests Failure on metric 
     * Failure on metric is a blocker. Base branch critical fail rate is 0,0%   
   * [Snapshots 4](https://ci2.ignite.apache.org/viewLog.html?buildId=9072480): 1 tests
     * `IgniteSnapshotTestSuite4`: `IgniteCacheDumpSelfTest.testDumpCancelOnIteratorWriteError[nodes=3,backups=0,persistence=true,mode=TRANSACTIONAL,useDataStreamer=false,onlyPrimary=false,encrypted=false]` - Test has low fail rate in base branch 0,0% and is not flaky
   * [Cache 9](https://ci2.ignite.apache.org/viewLog.html?buildId=9072382): 1 tests
     * `IgniteCacheTestSuite9`: `TxPartitionCounterStateOnePrimaryTwoBackupsTest.testPrepareOnlyTxFailover_3TX_1` - Test has low fail rate in base branch 0,0% and is not flaky
   * [PDS 7](https://ci2.ignite.apache.org/viewLog.html?buildId=9072429): 0 tests Failure on metric 
     * Failure on metric is a blocker. Base branch critical fail rate is 0,0%   
   
   #### New Tests (0)
   
   No new tests found.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org