You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/03/20 22:31:13 UTC
[GitHub] [samza] cameronlee314 opened a new pull request #1324: SAMZA-2481:
Improve memory usage in samza-core unit tests
cameronlee314 opened a new pull request #1324: SAMZA-2481: Improve memory usage in samza-core unit tests
URL: https://github.com/apache/samza/pull/1324
Symptom: `samza-core` requires `maxHeapSize` set to 4g when running unit tests. Otherwise, the test suite may hang or fail (especially in the CI pipeline).
Cause: `TestZkMetadataStore` has some tests around large values being written to zookeeper. That test uses an embedded zookeeper which does a lot of debug logging. The current logging impl for samza-core unit tests is the log4j v1 impl, which somehow defaults to DEBUG logging.
Changes: Use log4j2 logging impl for unit tests, since it seems to default to ERROR logging. We don't need the unit tests of the committed code to report DEBUG logging.
Tests: `./gradlew :samza-core:test` no longer hangs with a lower memory allocation. Before this change, it would hang.
API changes: log4j2 version increased from `2.11.0` to `2.12.0`, so any apps depending on `samza-log4j2` will transitively pull in the new version.
Upgrade/usage instructions: N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] cameronlee314 merged pull request #1324: SAMZA-2481:
Improve memory usage in samza-core unit tests
Posted by GitBox <gi...@apache.org>.
cameronlee314 merged pull request #1324: SAMZA-2481: Improve memory usage in samza-core unit tests
URL: https://github.com/apache/samza/pull/1324
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services