You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/06 07:25:27 UTC

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4374: Fixing searchAndCount searchAndDistinctCount when sc is null

davidjumani commented on a change in pull request #4374:
URL: https://github.com/apache/cloudstack/pull/4374#discussion_r500059151



##########
File path: framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java
##########
@@ -519,7 +509,6 @@ public T lockOneRandomRow(final SearchCriteria<T> sc, final boolean exclusive) {
         if (_removed != null) {
             sc.addAnd(_removed.second().field.getName(), SearchCriteria.Op.NULL);

Review comment:
       Makes it a bit difficult since it is of a different type M not T




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org