You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/06/19 22:45:05 UTC
Review Request 22788: Dropping the "Tasks killed" message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-533
https://issues.apache.org/jira/browse/AURORA-533
Repository: aurora
Description
-------
Dropping the "Tasks killed" message.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 3616b3e93010c9482dc96d94bdeb42eddae41fb0
Diff: https://reviews.apache.org/r/22788/diff/
Testing
-------
gradle build
Thanks,
Maxim Khutornenko
Re: Review Request 22788: Dropping the "Tasks killed" message.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/#review46224
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 19, 2014, 1:45 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22788/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 1:45 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-533
> https://issues.apache.org/jira/browse/AURORA-533
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping the "Tasks killed" message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 3616b3e93010c9482dc96d94bdeb42eddae41fb0
>
> Diff: https://reviews.apache.org/r/22788/diff/
>
>
> Testing
> -------
>
> gradle build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22788: Dropping the "Tasks killed" message.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 19, 2014, 8:49 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 624
> > <https://reviews.apache.org/r/22788/diff/1/?file=613376#file613376line624>
> >
> > Consider okEmptyResponse().
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/#review46225
-----------------------------------------------------------
On June 19, 2014, 8:45 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22788/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 8:45 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-533
> https://issues.apache.org/jira/browse/AURORA-533
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping the "Tasks killed" message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 3616b3e93010c9482dc96d94bdeb42eddae41fb0
>
> Diff: https://reviews.apache.org/r/22788/diff/
>
>
> Testing
> -------
>
> gradle build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22788: Dropping the "Tasks killed" message.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/#review46225
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22788/#comment81520>
Consider okEmptyResponse().
- Bill Farner
On June 19, 2014, 8:45 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22788/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 8:45 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-533
> https://issues.apache.org/jira/browse/AURORA-533
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping the "Tasks killed" message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 3616b3e93010c9482dc96d94bdeb42eddae41fb0
>
> Diff: https://reviews.apache.org/r/22788/diff/
>
>
> Testing
> -------
>
> gradle build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22788: Dropping the "Tasks killed" message.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/
-----------------------------------------------------------
(Updated June 19, 2014, 10:25 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-533
https://issues.apache.org/jira/browse/AURORA-533
Repository: aurora
Description
-------
Dropping the "Tasks killed" message.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 3616b3e93010c9482dc96d94bdeb42eddae41fb0
Diff: https://reviews.apache.org/r/22788/diff/
Testing
-------
gradle build
Thanks,
Maxim Khutornenko
Re: Review Request 22788: Dropping the "Tasks killed" message.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/
-----------------------------------------------------------
(Updated June 19, 2014, 10:24 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Bugs: AURORA-533
https://issues.apache.org/jira/browse/AURORA-533
Repository: aurora
Description
-------
Dropping the "Tasks killed" message.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 3616b3e93010c9482dc96d94bdeb42eddae41fb0
Diff: https://reviews.apache.org/r/22788/diff/
Testing
-------
gradle build
Thanks,
Maxim Khutornenko