[jira] [Commented] (OAK-4544) Fix failing test DataStoreCheckTest.testMissingOpParams()

["Woonsan Ko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365575#comment-15365575 ] 

Woonsan Ko commented on OAK-4544:
---------------------------------

Just out of curiosity, I printed out {{message}} and {{assertMsg}} on the failing method ({{DataStoreCheckTest#testIncorrectParams()}}):

{noformat}
$$$$$$$$$$ message: 'joptsimple.MissingRequiredOptionException: Missing required option(s) ['ref', 'id', 'consistency']
Option          Description                        
------          -----------                        
-?, -h, --help  show help                          
--consistency   Check consistency                  
--dump          Dump Path                          
--id            Get ids                            
--ref           Get references                     
--segment-tar   Use oak-segment-tar instead of oak-
                  segment                          
--store         Node Store                         
'
$$$$$$$$$$ assertMsg: 'Missing required option(s) ['id', 'ref', 'consistency']'
{noformat}

It looks like caused simply by inconsistent string representations of the options.

> Fix failing test DataStoreCheckTest.testMissingOpParams()
> ---------------------------------------------------------
>
>                 Key: OAK-4544
>                 URL: https://issues.apache.org/jira/browse/OAK-4544
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: run
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>            Priority: Minor
>             Fix For: 1.5.6
>
>
> DataStoreCheckTest.testMissingOpParams() regularly fails on Java 1.8. The test is a non-critical test which checks for proper messages for an operation which should be no-op given incomplete parameters.  If a solution cannot be found then it might still be ok to even remove the test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)