You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/11 15:19:57 UTC
[GitHub] [arrow-rs] medwards opened a new pull request #285: Fix subtraction underflow when sorting string arrays with many nulls
medwards opened a new pull request #285:
URL: https://github.com/apache/arrow-rs/pull/285
# Rationale for this change
String arrays follow a different code path than primitive arrays so updating to match #326 https://github.com/apache/arrow-rs/pull/236
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me merged pull request #285: Fix subtraction underflow when sorting string arrays with many nulls
Posted by GitBox <gi...@apache.org>.
nevi-me merged pull request #285:
URL: https://github.com/apache/arrow-rs/pull/285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] medwards commented on pull request #285: Fix subtraction underflow when sorting string arrays with many nulls
Posted by GitBox <gi...@apache.org>.
medwards commented on pull request #285:
URL: https://github.com/apache/arrow-rs/pull/285#issuecomment-838792534
> If I understand, this was similar to the bug in primitive types and it has the same resolution here. +1
That's correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #285: Fix subtraction underflow when sorting string arrays with many nulls
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #285:
URL: https://github.com/apache/arrow-rs/pull/285#issuecomment-838915280
Thank you @medwards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me commented on pull request #285: Fix subtraction underflow when sorting string arrays with many nulls
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #285:
URL: https://github.com/apache/arrow-rs/pull/285#issuecomment-840496980
Done @medwards @jhorstmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #285: Fix subtraction underflow when sorting string arrays with many nulls
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #285:
URL: https://github.com/apache/arrow-rs/pull/285#issuecomment-838774107
@alamb @jorgecarleitao This is a bugfix for an issue we had with sorting strings or dictionary encoded strings in our system, would be great to get a quick review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org