You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/14 16:39:12 UTC

[GitHub] [beam] pabloem commented on a change in pull request #13516: Change the output type of FHIR Search from String to JsonArray

pabloem commented on a change in pull request #13516:
URL: https://github.com/apache/beam/pull/13516#discussion_r542530282



##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIOTest.java
##########
@@ -67,7 +68,8 @@ public void test_FhirIO_failedSearches() {
 
     PCollection<HealthcareIOError<String>> failed = searchResult.getFailedSearches();
 
-    PCollection<String> resources = searchResult.getResources();
+    PCollection<JsonArray> resources = searchResult.getResources();
+    resources.setCoder(JsonArrayCoder.of());

Review comment:
       I recommend you set the coder from inside your `expand` function in `FhirIO.java` - that way your users will not need to set their coders manually every time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org